From owner-p4-projects@FreeBSD.ORG  Wed Mar 29 22:09:02 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 47EEF16A427; Wed, 29 Mar 2006 22:09:02 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 256C916A400
	for <perforce@freebsd.org>; Wed, 29 Mar 2006 22:09:02 +0000 (UTC)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AE90043D5E
	for <perforce@freebsd.org>; Wed, 29 Mar 2006 22:08:57 +0000 (GMT)
	(envelope-from marcel@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k2TM8v6c077697
	for <perforce@freebsd.org>; Wed, 29 Mar 2006 22:08:57 GMT
	(envelope-from marcel@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k2TM8vj8077694
	for perforce@freebsd.org; Wed, 29 Mar 2006 22:08:57 GMT
	(envelope-from marcel@freebsd.org)
Date: Wed, 29 Mar 2006 22:08:57 GMT
Message-Id: <200603292208.k2TM8vj8077694@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	marcel@freebsd.org using -f
From: Marcel Moolenaar <marcel@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 94264 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Mar 2006 22:09:02 -0000

http://perforce.freebsd.org/chv.cgi?CH=94264

Change 94264 by marcel@marcel_nfs on 2006/03/29 22:08:51

	Fix braino: We keep track of line signal changes even if
	the device isn't open. This means that when a device gets
	opened, sc_ttypend may not be 0 and we will therefore
	never schedule the SWI. Do what I intended and limit the
	test to the interrupt pending bits.

Affected files ...

.. //depot/projects/uart/dev/uart/uart_core.c#50 edit

Differences ...

==== //depot/projects/uart/dev/uart/uart_core.c#50 (text+ko) ====

@@ -84,7 +84,7 @@
 		new = old | ipend;
 	} while (!atomic_cmpset_32(&sc->sc_ttypend, old, new));
 
-	if (old == 0)
+	if ((old & SER_INT_MASK) == 0)
 		swi_sched(sc->sc_softih, 0);
 }