Date: Fri, 9 May 2014 21:55:42 +0200 From: Tijl Coosemans <tijl@FreeBSD.org> To: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Raphael Kubo da Costa <rakuco@freebsd.org>, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r353466 - head/astro/cfitsio Message-ID: <20140509215542.2a706619@kalimero.tijl.coosemans.org> In-Reply-To: <CAMHz58Rb6DL%2BRXjNUa583mg7sOSfK7zj1FDupRj1eG8V=FdRHg@mail.gmail.com> References: <201405091526.s49FQ5HW013837@svn.freebsd.org> <20140509181117.335833e7@kalimero.tijl.coosemans.org> <CAMHz58Rb6DL%2BRXjNUa583mg7sOSfK7zj1FDupRj1eG8V=FdRHg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 10 May 2014 03:38:03 +0800 Sunpoet Po-Chuan Hsieh wrote: > On Sat, May 10, 2014 at 12:11 AM, Tijl Coosemans <tijl@freebsd.org> wrote: >> On Fri, 9 May 2014 15:26:05 +0000 (UTC) Sunpoet Po-Chuan Hsieh wrote: >>> Author: sunpoet >>> Date: Fri May 9 15:26:05 2014 >>> New Revision: 353466 >>> URL: http://svnweb.freebsd.org/changeset/ports/353466 >>> QAT: https://qat.redports.org/buildarchive/r353466/ >>> >>> Log: >>> - Pass -lz to libdata/pkgconfig/cfitsio.pc >>> - Bump PORTREVISION for package change >>> >>> PR: ports/189487 >>> Submitted by: rakuco >> >> Can you patch cfitsio.pc to move @LIBS@ to the Libs.private field? >> Other ports run 'pkg-config --libs cfitsio' to know what libraries >> to link to and the output of that includes -lz now. >> "-L${LIBDIR}" can be removed I think. All compilers should search >> it by default. > > I prepared a new patch [1] which reverted r353466 and patched cfitsio.pc. > It's OK in my tinderbox. > Would you please check if it works for you? > Thanks! > > [1] https://people.freebsd.org/~sunpoet/cfitsio.patch I think this may reintroduce the problem that Raphael reported. The problem is a line in Makefile.in that says "LDFLAGS=$(CFLAGS)". If you add this to post-patch it'll be ok I think: @${REINPLACE_CMD} -e '/^LDFLAGS =/ s|$$| @LDFLAGS@|' ${WRKSRC}/Makefile.in To fix the PR the output of "ldd libcfitsio.so" must contain libz.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140509215542.2a706619>