From owner-svn-src-stable@freebsd.org Wed Aug 15 17:43:14 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EE71D106A2D4; Wed, 15 Aug 2018 17:43:13 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 583867113A; Wed, 15 Aug 2018 17:43:13 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w7FHhBOm048919; Wed, 15 Aug 2018 10:43:11 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w7FHhBT9048918; Wed, 15 Aug 2018 10:43:11 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201808151743.w7FHhBT9048918@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r337826 - stable/11/bin/ls In-Reply-To: To: Adam Weinberger Date: Wed, 15 Aug 2018 10:43:11 -0700 (PDT) CC: kevans@freebsd.org, rgrimes@freebsd.org, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, emaste@freebsd.org, svn-src-stable-11@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 17:43:14 -0000 [ Charset UTF-8 unsupported, converting... ] > On Wed, Aug 15, 2018 at 11:31 AM Kyle Evans wrote: > > > > On Wed, Aug 15, 2018 at 11:07 AM, Rodney W. Grimes > > wrote: > > > [ Charset UTF-8 unsupported, converting... ] > > >> On 14 August 2018 at 21:41, Rodney W. Grimes > > >> wrote: > > >> >> Author: kevans > > >> >> Date: Wed Aug 15 01:29:02 2018 > > >> >> New Revision: 337826 > > >> >> URL: https://svnweb.freebsd.org/changeset/base/337826 > > >> >> > > >> >> Log: > > >> >> MFC r337506: ls(1): Enable colors with COLORTERM is set in the environment > > >> >> > > >> >> COLORTERM is the de facto standard, while CLICOLOR is generally specific to > > >> >> FreeBSD and ls(1). > > >> > > > >> > I have already seen one "Who enabled %&*@(#$@) colored ls output in 12?" > > >> > Seems that the defaults for xfce terminal is to have COLORTERM. > > >> > > >> If xfce's default is to request colour via the de-facto environment > > >> variable then we should generally honour it -- the answer to the > > >> %&*@(#$@) question is "you did, via your terminal's default." > > > > > > And I pointed that out to them, but it is kinda a POLA, people have > > > had to take explicit action to get colorls, that is no longer true > > > and that suprises them when they see it. > > > > > > > I find the POLA angle kind-of hard to buy, though. Nothing in the base > > system offers a way for the default behavior of ls(1) to be altered, > > and this whole change is only honoring a de-facto standard for > > indicating that a colored terminal is supported and desired. > > > > IMO, one should be aware of how the software they use is affecting > > their environment and the kinds of repercussions these changes may > > have. This is hardly the first bit of software that respects > > COLORTERM, and it surely won't be the last (in general... no specific > > plans here). =( > > Respecting the same env var that other OS's do seems like a reduction in POLA. > > Please consider putting a note in one or more of /usr/src/UPDATING, > /usr/ports/UPDATING, and xfce/pkg-message explaining the change and > what people should do to get the old behaviour. They're the best tools > we have for improving POLA. >From the Linux man page at: http://man7.org/linux/man-pages/man1/ls.1.html Using color to distinguish file types is disabled both by default and with --color=never. With --color=auto, ls emits color codes only when standard output is connected to a terminal. The LS_COLORS environment variable can change the settings. Use the dircolors command to set it. Um, so by default we should not be doing any colour... and we are... > > # Adam > > > -- > Adam Weinberger > adamw@adamw.org > https://www.adamw.org > -- Rod Grimes rgrimes@freebsd.org