From owner-freebsd-current Sat May 6 22:39:30 2000 Delivered-To: freebsd-current@freebsd.org Received: from ipt2.iptelecom.net.ua (ipt2.iptelecom.net.ua [212.9.224.2]) by hub.freebsd.org (Postfix) with ESMTP id 5C67437B67D for ; Sat, 6 May 2000 22:39:22 -0700 (PDT) (envelope-from sobomax@altavista.net) Received: from altavista.net (dialup4-10.iptelecom.net.ua [212.9.226.202]) by ipt2.iptelecom.net.ua (8.9.3/8.9.3) with ESMTP id IAA10767; Sun, 7 May 2000 08:39:45 +0300 (EEST) Message-ID: <39150252.1BCB4EBE@altavista.net> Date: Sun, 07 May 2000 08:42:42 +0300 From: Maxim Sobolev Organization: Home, sweet home X-Mailer: Mozilla 4.72 [en] (Win98; I) X-Accept-Language: uk,ru,en MIME-Version: 1.0 To: Bruce Evans Cc: current@FreeBSD.ORG Subject: Re: Small MAKEDEV bug References: Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Bruce Evans wrote: > On Sat, 6 May 2000, Maxim Sobolev wrote: > > > I've just noticed that "sh MAKEDEV acd1" doesn't produce node for acd1 due to > > incorrect comparasion in the "while" loop. This affecting both 4.0-STABLE and > > 5.0-CURRENT. With this message I'm attaching short patch which should solve > > this little problem. > > This is the intended behaviour. "sh MAKEDEV acdN" is supposed to create > N acd devices, numbered from 0 to N-1. This broken behaviour was introduced > for cd*, mcd* and scd* in rev.1.171. It has since spread to acd*. Other > types of disks are handled correctly. How broken behaviour could be "intended"? It is unclear why *cd* devices should be different from all others types of disk devices. Users usually being confused when dealing with special cases like that. I think that there will be no problem if it would create N+1 devices at least until someone will reimplement it correctly. -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message