From owner-freebsd-mozilla@FreeBSD.ORG Sat Apr 12 13:45:24 2003 Return-Path: Delivered-To: freebsd-mozilla@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D0D9B37B401; Sat, 12 Apr 2003 13:45:24 -0700 (PDT) Received: from ms-smtp-03.southeast.rr.com (ms-smtp-03.southeast.rr.com [24.93.67.84]) by mx1.FreeBSD.org (Postfix) with ESMTP id B8B6A43F93; Sat, 12 Apr 2003 13:45:23 -0700 (PDT) (envelope-from marcus@marcuscom.com) Received: from mail3.nc.rr.com (fe3 [24.93.67.50])h3CKi7Mq000471; Sat, 12 Apr 2003 16:44:07 -0400 (EDT) Received: from creme-brulee.marcuscom.com ([66.57.17.158]) by mail3.nc.rr.com with Microsoft SMTPSVC(5.5.1877.757.75); Sat, 12 Apr 2003 16:42:49 -0400 Received: from [192.168.1.4] (shumai.marcuscom.com [192.168.1.4]) h3CKiVaa053760; Sat, 12 Apr 2003 16:44:32 -0400 (EDT) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Pav Lucistnik In-Reply-To: <1050156140.48539.36.camel@pav.oook.cz> References: <1050144588.48539.7.camel@pav.oook.cz> <1050156140.48539.36.camel@pav.oook.cz> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-XKjCnJPgxARHR+l4MVra" Organization: MarcusCom, Inc. Message-Id: <1050180316.72359.14.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.4 Date: 12 Apr 2003 16:45:17 -0400 X-Spam-Status: No, hits=-39.4 required=5.0 tests=BAYES_01,EMAIL_ATTRIBUTION,IN_REP_TO,PGP_SIGNATURE_2, QUOTED_EMAIL_TEXT,QUOTE_TWICE_1,REFERENCES, REPLY_WITH_QUOTES autolearn=ham version=2.50 X-Spam-Checker-Version: SpamAssassin 2.50 (1.173-2003-02-20-exp) cc: freebsd-mozilla@freebsd.org cc: freebsd-gnome@freebsd.org Subject: Re: galeon-1.2.9 gettext build problem X-BeenThere: freebsd-mozilla@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Mozilla browser issues List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Apr 2003 20:45:25 -0000 --=-XKjCnJPgxARHR+l4MVra Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2003-04-12 at 10:02, Pav Lucistnik wrote: > V so, 12. 04. 2003 v 12.49, Pav Lucistnik napsal: >=20 > > Hi, I'm updating Mozilla/Galeon on my 5.0-RELEASE system. Galeon > > compilation bombs on undefined Lgettext: > >=20 > > ContentHandler.cpp: In member function `virtual nsresult=20 > > GContentHandler::PromptForSaveToFile(nsISupports*, const PRUnichar*, > > const=20 > > PRUnichar*, nsILocalFile**)': > > ContentHandler.cpp:367: `Lgettext' undeclared (first use this function) >=20 > > Problematic line is: > > NS_NAMED_LITERAL_STRING (title, _("Select the destination filename")); >=20 > Tracked it down to macro expansion: >=20 > Mozilla header string/nsLiteralString.h defines: >=20 > #define NS_NAMED_LITERAL_STRING(n,s) > NS_NAMED_MULTILINE_LITERAL_STRING(n, NS_LL(s)) >=20 > and >=20 > #define NS_L(s) NS_LL(s) Actually, it should be expanded by NS_LL, which is, in turn, expanded to L##s (whatever). >=20 > so it looks like my compiler expands NS_NAMED_LITERAL_STRING macro, and > then when looking how to expand NS_LL(s) macro it used NS_L(s) macro > instead of desired NS_LL(s) macro... >=20 > My C++ skills ends here :( anyone can help? My gcc is stock from 5.0: >=20 > # c++ -v > Using built-in specs. > Configured with: FreeBSD/i386 system compiler > Thread model: posix > gcc version 3.2.1 [FreeBSD] 20021119 (release) >=20 > I don't have any non-standard options in /etc/make.conf The Galeon people already fixed it. I merged in their fix. Thanks for reporting! Joe --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-XKjCnJPgxARHR+l4MVra Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQA+mHrcb2iPiv4Uz4cRAsF5AJ0UPYbDBwwFfnsHaJdj6Bk+V6/yYQCfVA5d HExO9uwzRzSr2UW+HJ3ZhiY= =Wfo8 -----END PGP SIGNATURE----- --=-XKjCnJPgxARHR+l4MVra--