From owner-freebsd-bugs  Thu Mar 11  9:20:17 1999
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id CC95315249
	for <freebsd-bugs@FreeBSD.org>; Thu, 11 Mar 1999 09:20:14 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.2/8.9.2) id JAA18886;
	Thu, 11 Mar 1999 09:20:01 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from scotts-laptop.dcs.qmw.ac.uk (scotts-laptop.dcs.qmw.ac.uk [138.37.89.8])
	by hub.freebsd.org (Postfix) with ESMTP id 731EC150DC
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 11 Mar 1999 09:18:06 -0800 (PST)
	(envelope-from root@scotts-laptop.dcs.qmw.ac.uk)
Received: (from root@localhost)
	by scotts-laptop.dcs.qmw.ac.uk (8.9.1/8.8.8) id RAA00740;
	Thu, 11 Mar 1999 17:18:30 GMT
	(envelope-from root)
Message-Id: <199903111718.RAA00740@scotts-laptop.dcs.qmw.ac.uk>
Date: Thu, 11 Mar 1999 17:18:30 GMT
From: scott@dcs.qmw.ac.uk
Reply-To: scott@dcs.qmw.ac.uk
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: bin/10546: Intel Pro/100 PC card has CIS string > CIS_MAXSTR
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         10546
>Category:       bin
>Synopsis:       Intel Pro/100 PC card has CIS string > CIS_MAXSTR
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Mar 11 09:20:01 PST 1999
>Closed-Date:
>Last-Modified:
>Originator:     Scott Mitchell
>Release:        FreeBSD 3.0-RELEASE i386
>Organization:
Queen Mary & Westfield College
>Environment:

Any machine with PCCARD support enabled.

>Description:

CIS_MAXSTR is defined as 30 in /usr/src/usr.sbin/pccard/pccardd/readcis.h.
Certain PCMCIA cards (eg. The Intel EtherExpress Pro Mobile 10/100) contain
strings in their CIS tuples that are longer than 30 characters.  In the case
of the Intel there's a 48 byte string, other cards may have longer strings.

>How-To-Repeat:

Run pccardd, insert a PC card with a CIS string longer than 30 characters.

>Fix:

Bump the value of CIS_MAXSTR upwards.  The maximum possible amount of data in
a CIS tuple is 254 bytes, so this should be enough to cover anything...
	
The following patch does the necessary:

*** readcis.h.orig	Tue Sep 23 20:51:32 1997
--- readcis.h	Thu Mar 11 16:52:49 1999
***************
*** 26,32 ****
   * $Id: readcis.h,v 1.9 1997/09/23 19:51:32 nate Exp $
   */
  
! #define	CIS_MAXSTR	30
  struct tuple {
  	struct tuple *next;
  	unsigned char code;
--- 26,32 ----
   * $Id: readcis.h,v 1.9 1997/09/23 19:51:32 nate Exp $
   */
  
! #define	CIS_MAXSTR	254
  struct tuple {
  	struct tuple *next;
  	unsigned char code;



>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message