From owner-freebsd-transport@freebsd.org Sun Apr 18 14:54:42 2021 Return-Path: Delivered-To: freebsd-transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C25A95EB7BD for ; Sun, 18 Apr 2021 14:54:42 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4FNXzQ2Gvxz3ks5 for ; Sun, 18 Apr 2021 14:54:42 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: by mailman.nyi.freebsd.org (Postfix) id 4C4415EB7BB; Sun, 18 Apr 2021 14:54:42 +0000 (UTC) Delivered-To: transport@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 4A6ED5EB4EA for ; Sun, 18 Apr 2021 14:54:42 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on20603.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eae::603]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FNXzQ0ZvZz3kf9 for ; Sun, 18 Apr 2021 14:54:41 +0000 (UTC) (envelope-from Richard.Scheffenegger@netapp.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UsRu2mbk26R+BeXfSbnTCprUcLMxlKeyiNXg+iQ0Hh5+ESZi3oFJPwbiqDkdu3jo481jBMFwRc9jYIIeNveCdJ5DfbKbMf6/mwMyme2FvXIOvrJymTgrSMCKDs8ZBWl4d2h6/63kSzX4PfuTfhb/q+C4ZfivHgRBPpcQgPcOcyW2k60TuMPYVCtyEbKiU/Yk9OHO/jwgFyeaqMtr07YXV3/zCcpOn3xTCwr45Woc42RHF6atoNKOMezyN08HLla0/KEanrGjp51v+OexlUcCRrtdANjM7y1xu2T3vpFBYdo0AVl0Sg/WK36BePzQkQz5eAMJSMNe7g//vdNl9/uFfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vnx1fCL5GgfUU5ca8qmjWmTYMulGwaTIyVp67K/Io5Y=; b=RAB5bS+cXg47LH9oIETDNj4WJ/5xC5E6gIvZ0CP5VBE7POCdEg7MIO/ayRAra/rLhgq5YQQ4FFbm/CYaKjg5nKtonI8Q1LjSWEJ+84/4JrJooz+ICJQmP1R4HgCf8iSdsRLk9+CN68O0m9uXHp27o/bPuNvcLFRHBYt1ugqJq69t7xqYEdootjempAKTtS/yhlacLvVIZOaIhyi9fK9vvYNRYRwuhMuupqIJRi/xg//E9OBEkbYMBklrwDxv8n8Yd6qFUvkRcBVMAFDkTPwj9ikMX7mPEWZaty6E/T+pLZli4r3Gxnk+Z2FbSeySgp5n0mFdQRV/awdgUl4fCBAn4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=netapp.com; dmarc=pass action=none header.from=netapp.com; dkim=pass header.d=netapp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netapp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vnx1fCL5GgfUU5ca8qmjWmTYMulGwaTIyVp67K/Io5Y=; b=jrLj0t91eGDgchW8/tKnXU83BamOuiYoHIxWQq+lJi2PNOqaeJLRf3WdY2mWnu0Zb4CvFBCz2feuvABv2oh+crcmo0LPBjtBeyAa8VBGsk4pf7eDTJ4MrcjGapUGCJt1VMvY5MhbKYkaGtcMbITHjkF8Uf3Ue3oEORTlLW8bitQBfWtq/j1Nir6TqOCsxKjXgD1DEeKa+J1M6dIP/Vkj9yhzLYcbzXlhe8FNkCtTl1az1KTbtg40q4UIhN76qD2yIkTOWqWsfweoOnbmq7P1G//UWjuLNUtoME+CBA8//ncURpXRzp5vs6NCTTibNSHU+JlRJvaCpBkZXo0X9WrE1A== Received: from PH0PR06MB7639.namprd06.prod.outlook.com (2603:10b6:510:4e::18) by PH0PR06MB7477.namprd06.prod.outlook.com (2603:10b6:510:5e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.18; Sun, 18 Apr 2021 14:54:38 +0000 Received: from PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda]) by PH0PR06MB7639.namprd06.prod.outlook.com ([fe80::19e2:b5f4:2a64:5eda%5]) with mapi id 15.20.4042.024; Sun, 18 Apr 2021 14:54:38 +0000 From: "Scheffenegger, Richard" To: Peter Holm CC: "transport@freebsd.org" Subject: AW: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Thread-Topic: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.revised, and enable by default Thread-Index: AQHXM5CiCqQV41lYIEC3c4/iyC2cxKq5yTAAgAAndzCAAAvZgIAAWrhw Date: Sun, 18 Apr 2021 14:54:38 +0000 Message-ID: References: <202104171350.13HDoPQL025776@gitrepo.freebsd.org> <20210418060040.GA48834@x8.osted.lan> <20210418090419.GA51040@x8.osted.lan> In-Reply-To: <20210418090419.GA51040@x8.osted.lan> Accept-Language: de-AT, en-US Content-Language: de-DE X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [185.236.167.136] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ba205d5-beae-4d52-d3b2-08d90279e399 x-ms-traffictypediagnostic: PH0PR06MB7477: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1169; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +/37LYeFDav9af2aBHrnS2M9e8AY8cAAXkBe5nYlk8Jx+aRn/s6FO4U/+EUE/cUiODMV/wkl0JU52SBUot76Dqkq+fJV7mqmw4erqxjdKG6uhbi4banEcrVhoudyXV9E6NMJyw7DCvtP0I9UVmzmNkyrSYNJWCBHoI9WS1Kkgf+aEcTY9DF/WgON6iR9jgKm/Ytmi6yJerGTM9XdlQn1VkZ3P7eRy9TgrXUke0yMU5PrUE/HFi0tyv0gJ8lQiRTYOU6bn7J9YWUsHFgFNJYIFbnUO97nDLMYHcFDbNEmwS8QCUcPHgooitXl5JgBmk6vhac49NE8JuXqSL61drMaQ9OUrzVj4Bry/sC4izPB9a2FfjxEehweZqP9U4UyTeH1iKoukWdursuHSjZ9OtvappMY9tUGnksoN/Wf24FUBf95DnD0JU/Jo2hqfRLeB1q5mos12PtqXZzUVemZhvpi69dTXwl1VG0AbeVHG71/tSxQcyN75t/IofZuE8B/rJkXTiL7K7tuHDDQyIamoIMebPA/m4g9lU2rKD0UyxyDSvB+ZqWVrgnHw1u4k50W7Zbu16WNonW878YX4Tp3nmZCks9piK2trgGGJ6v3nvBz743qilLlg+7XxPtwImpGa+Jc6gr7LzO8Vwr+5/PkVKfMMVXhrsJXwEco6w9RENwYCyjl53a2qxsaapiz7B39ZW2w x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR06MB7639.namprd06.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(39860400002)(346002)(376002)(396003)(8676002)(38100700002)(71200400001)(8936002)(33656002)(6916009)(186003)(478600001)(4326008)(122000001)(9686003)(6506007)(86362001)(966005)(2906002)(5660300002)(26005)(66476007)(66446008)(64756008)(76116006)(66556008)(316002)(7696005)(66574015)(83380400001)(55016002)(52536014)(66946007); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?oPbrCWx0kG8SUjEhs3Uz9E4RogNkDaSQrpVIqIbNvUeu8v43r/CJxIJUuQ?= =?iso-8859-1?Q?plCvLMg4CtpCVzdbEPlzuvRlwDijT+Vyu96wyTNh5mQ3mmOpp3fMhmSTkq?= =?iso-8859-1?Q?qsDV1gISeaj5NRo0nOCbR5imfcP/XYSOLnYSILngPZc+DyjJQGdXbSN3Xo?= =?iso-8859-1?Q?nMQOXITLZ3vWB80AqDp440r5gJcx3neWRl35Ls7bdCBBTiw8kxZgiHSX9u?= =?iso-8859-1?Q?t0JN+B9WHws6f2kufIolUNz9J5qPCVKs5bC8bIH4KfbAS/Ox2jYITBhuCn?= =?iso-8859-1?Q?3ga9kTvWfz6tQQcrFQCR/nDsUXmYTrNzYs402zjG9eaqXdaKHNQipNxt32?= =?iso-8859-1?Q?KIb9tZIvHr+F7n2e9D96FaiUfNvVy8eyRAWEBnLO9TfG2Po8zoqaMGbMH+?= =?iso-8859-1?Q?H4nRrscEOorgKNECOAJPz51yQZbKIbaHUhVAjeYy87LKQASze1E+1/fn64?= =?iso-8859-1?Q?c4VhGQfA+KXf9RHwmX47R2BCecHnxj4j/5K++/u5A8iSg3hX49QwDpBqUH?= =?iso-8859-1?Q?eOOJp/GfThyem3ggRFt/GrNu/5P8Ob3fwG0ckAZB3r841iFYlQy/FEdmjL?= =?iso-8859-1?Q?8a/xC8JltrVIO/Hs2iz4ocU1Pr4A23K8kBsQp+JRqyji5UgFeG6wTk6vQ2?= =?iso-8859-1?Q?mRLR5cw0yY5kCopvQxbk7T1H6d7+SzRyWrfdjqPCRWA2pHDUjwGClZYBlA?= =?iso-8859-1?Q?TBvGaSB4R6sLKzv0HvaiDlDWLOulRgKGakmoYj5nsTfxhbpbN0CpDrZsgy?= =?iso-8859-1?Q?JKmi/oQPtDsiuhCLjiZgAshmTOawhzuXmF2eQX8UeNE+XmGgPK+tSsnHJw?= =?iso-8859-1?Q?R7oFscMMz7cgsC5y08ufCK8ymFclE4Wjh8ardS4k50U3gMs0ghVk1BVduL?= =?iso-8859-1?Q?YvRWZ2N/1hUoWcy6SHJPGYKLYSIubmD6N7vzw1pAFEdmQooXHiCeTou2FI?= =?iso-8859-1?Q?5OLLp20SVKwsTYLEobr2I4DiVSbeW2/dwWC0UXXA4BVpjBnvUwI9JOjafV?= =?iso-8859-1?Q?1yJiloPG7/Yr1HIqiHg6KV+4RUoBnGZYsGYOE2J+VpWKVSiX2FkEHnSaSZ?= =?iso-8859-1?Q?fXnYciLqfLepk6PiCUGPk+WKtqMnGxmmJuSCQli3RPtqcyYap9kmFnyRTB?= =?iso-8859-1?Q?Y9jFEjg5JROlqfXv/QxY7AuTwVQSsdJrmjY1/qTrDCUfY74Qf6B369E8Ei?= =?iso-8859-1?Q?S6LczhonW9FobDBQvmHAGR4FCjF4v/SBCdaeZ2rQ7FJUWVmwSjIaP1/BUT?= =?iso-8859-1?Q?I8pWcTe2WyepjQ/xCaCvQ1Ij5FhMAbuk8JSXW/q9qmFsAoNP3bXUdyKePX?= =?iso-8859-1?Q?qREfhWVEK6F2Fxj+F2yyYgQtfZr62dLHJTIyT9gqBvy85psBoWB/Ak4fWQ?= =?iso-8859-1?Q?hcmc/9z+rn?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: netapp.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR06MB7639.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ba205d5-beae-4d52-d3b2-08d90279e399 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Apr 2021 14:54:38.0969 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4b0911a0-929b-4715-944b-c03745165b3a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HIGAJBRyjlHK6nlGvA2CFxhE3MpBZ8khy4I7EKSsTTDQOL/XVSagADntkbHqnpwwObDq+Qm0ZsFhl01WoTEKSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR06MB7477 X-Rspamd-Queue-Id: 4FNXzQ0ZvZz3kf9 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-transport@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions of transport level network protocols in FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Apr 2021 14:54:42 -0000 It appears that the SACK scoreboard ended up unordered (the assumption/inva= riant is for it to remain sorted for efficient processing): tp->snd_holes 0xfffff80726393c00 3958849524 3958865856 0xfffff80726393bc0 3958816860 3958849524 0xfffff80726393ae0 3959110836 3959192496 The 2nd entry has lower sequence numbers than the first. The KASSERT happen= ed, when this hole was scheduled for retransmission, but snd_una already ac= knowledged it by that time... It seems the reproduction is stable, I will look into where this happens... Richard Scheffenegger -----Urspr=FCngliche Nachricht----- Von: owner-src-committers@freebsd.org Im= Auftrag von Peter Holm Gesendet: Sonntag, 18. April 2021 11:04 An: Scheffenegger, Richard Cc: Richard Scheffenegger ; src-committers@freebsd.org= ; dev-commits-src-all@freebsd.org; dev-commits-src-main@freebsd.org; transp= ort@freebsd.org Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to sack.re= vised, and enable by default NetApp Security WARNING: This is an external email. Do not click links or o= pen attachments unless you recognize the sender and know the content is saf= e. On Sun, Apr 18, 2021 at 08:30:20AM +0000, Scheffenegger, Richard wrote: > Hi Peter, > > Hmm... the panic appears to be due to a stale entry in the sack scoreboar= d - a hole not having been closed up to snd_una... > > Unlikely that this was solely due to this change by itself. > > Can I get the vmcore and kernel.debug for a close investigation? > Sure. Uploaded to: https://people.freebsd.org/~pho/kernel.vmcore.320-mercat= 1.tar - Peter > > Richard Scheffenegger > > -----Urspr=FCngliche Nachricht----- > Von: Peter Holm > Gesendet: Sonntag, 18. April 2021 08:01 > An: Richard Scheffenegger > Cc: src-committers@freebsd.org; dev-commits-src-all@freebsd.org;=20 > dev-commits-src-main@freebsd.org > Betreff: Re: git: d1de2b05a001 - main - tcp: Rename rfc6675_pipe to=20 > sack.revised, and enable by default > > NetApp Security WARNING: This is an external email. Do not click links or= open attachments unless you recognize the sender and know the content is s= afe. > > > > > On Sat, Apr 17, 2021 at 01:50:25PM +0000, Richard Scheffenegger wrote: > > The branch main has been updated by rscheff: > > > > URL: > > https://cgit.FreeBSD.org/src/commit/?id=3Dd1de2b05a001d3d80f633f576f49 > > 09 > > c2686dda3d > > > > commit d1de2b05a001d3d80f633f576f4909c2686dda3d > > Author: Richard Scheffenegger > > AuthorDate: 2021-04-17 12:59:30 +0000 > > Commit: Richard Scheffenegger > > CommitDate: 2021-04-17 12:59:45 +0000 > > > > tcp: Rename rfc6675_pipe to sack.revised, and enable by default > > > > As full support of RFC6675 is in place, deprecating > > net.inet.tcp.rfc6675_pipe and enabling by default > > net.inet.tcp.sack.revised. > > > > Reviewed By: #transport, kbowling, rrs > > Sponsored by: NetApp, Inc. > > Differential Revision: https://reviews.freebsd.org/D28702 > > --- > > share/man/man4/tcp.4 | 25 ++++++++++++++----------- > > sys/netinet/cc/cc_cubic.c | 2 +- > > sys/netinet/cc/cc_htcp.c | 2 +- > > sys/netinet/cc/cc_newreno.c | 2 +- > > sys/netinet/tcp_input.c | 11 +++-------- > > sys/netinet/tcp_sack.c | 12 +++++++++--- > > sys/netinet/tcp_var.h | 4 ++-- > > 7 files changed, 31 insertions(+), 27 deletions(-) > > > > diff --git a/share/man/man4/tcp.4 b/share/man/man4/tcp.4 index=20 > > d01505e58427..cbb8021226fe 100644 > > --- a/share/man/man4/tcp.4 > > Could this panic be related? > > 20210418 07:19:59 all (204/751): jumbo.sh > panic: tcp_output: sack block to the left of una : -293976 cpuid =3D 3=20 > time =3D 1618723234 > KDB: stack backtrace: > db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame=20 > 0xfffffe00e49b0550 > vpanic() at vpanic+0x181/frame 0xfffffe00e49b05a0 > panic() at panic+0x43/frame 0xfffffe00e49b0600 > tcp_output() at tcp_output+0x27dc/frame 0xfffffe00e49b07c0 > tcp_do_segment() at tcp_do_segment+0x32a3/frame 0xfffffe00e49b08b0 > tcp_input() at tcp_input+0xbd5/frame 0xfffffe00e49b0a10 > ip_input() at ip_input+0x194/frame 0xfffffe00e49b0aa0 > swi_net() at swi_net+0x1a1/frame 0xfffffe00e49b0b20 > ithread_loop() at ithread_loop+0x279/frame 0xfffffe00e49b0bb0 > fork_exit() at fork_exit+0x80/frame 0xfffffe00e49b0bf0 > fork_trampoline() at fork_trampoline+0xe/frame 0xfffffe00e49b0bf0 > --- trap 0, rip =3D 0, rsp =3D 0, rbp =3D 0 --- > > https://people.freebsd.org/~pho/stress/log/log0094.txt > > - Peter