From owner-freebsd-current  Thu Sep  9  3:29: 2 1999
Delivered-To: freebsd-current@freebsd.org
Received: from mpp.pro-ns.net (pppdsle45.mpls.uswest.net [216.160.23.45])
	by hub.freebsd.org (Postfix) with ESMTP id 0A3F614BEA
	for <freebsd-current@FreeBSD.ORG>; Thu,  9 Sep 1999 03:28:59 -0700 (PDT)
	(envelope-from mpp@mpp.pro-ns.net)
Received: (from mpp@localhost)
	by mpp.pro-ns.net (8.9.3/8.9.3) id FAA04357;
	Thu, 9 Sep 1999 05:28:24 -0500 (CDT)
	(envelope-from mpp)
From: Mike Pritchard <mpp@FreeBSD.org>
Message-Id: <199909091028.FAA04357@mpp.pro-ns.net>
Subject: Re: optional 'make release' speed-up patch
In-Reply-To: <199909090404.AAA71015@bb01f39.unx.sas.com> from "John W. DeBoskey" at "Sep 9, 1999 00:04:39 am"
To: jwd@unx.sas.com (John W. DeBoskey)
Date: Thu, 9 Sep 1999 05:28:24 -0500 (CDT)
Cc: freebsd-current@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> Hi,
> 
>    The following patch to /usr/src/release/Makefile allows the
> specification of the variable FASTCLEAN, which instead of doing
> a recursive rm on CHROOTDIR, simply umounts/newfs/mounts. Of
> course, this is only useful if your CHROOTDIR location is a
> separate mount point (which mine is: /snap).
> 
>    Comments and critiques welcome.
> 
>    Would someone consider committing this please?

This patch scares me a little.  FASTCLEAN should at a minimum
be set to some value, like "NEWFS" (and probably something a bit more
descriptive) before it goes around re-making file systems.  
I would hate to see my file system wiped out just because
I have the "FASTCLEAN" environment variable set for some other
application, and didn't intend for "make release" to use it.

-Mike
-- 
Mike Pritchard
mpp@FreeBSD.org or mpp@mpp.pro-ns.net


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message