From owner-freebsd-drivers@FreeBSD.ORG  Sat Feb 27 21:52:29 2010
Return-Path: <owner-freebsd-drivers@FreeBSD.ORG>
Delivered-To: freebsd-drivers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D4C501065672
	for <freebsd-drivers@freebsd.org>; Sat, 27 Feb 2010 21:52:29 +0000 (UTC)
	(envelope-from patfbsd@davenulle.org)
Received: from smtp.lamaiziere.net (net.lamaiziere.net [91.121.44.19])
	by mx1.freebsd.org (Postfix) with ESMTP id 9467D8FC12
	for <freebsd-drivers@freebsd.org>; Sat, 27 Feb 2010 21:52:29 +0000 (UTC)
Received: from baby-jane.lamaiziere.net (unknown [192.168.1.10])
	by smtp.lamaiziere.net (Postfix) with ESMTP id D12A363317E;
	Sat, 27 Feb 2010 22:52:27 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by baby-jane.lamaiziere.net (Postfix) with ESMTP id 1A5F62CEDB0;
	Sat, 27 Feb 2010 22:52:33 +0100 (CET)
Date: Sat, 27 Feb 2010 22:52:28 +0100
From: Patrick Lamaiziere <patfbsd@davenulle.org>
To: "freebsd-drivers@freebsd.org" <freebsd-drivers@freebsd.org>
Message-ID: <20100227225228.470e9b7b@davenulle.org>
In-Reply-To: <CFBC532374C38D45810FA00BC2D2C2041FB949@irsmsx502.ger.corp.intel.com>
References: <CFBC532374C38D45810FA00BC2D2C2041FB949@irsmsx502.ger.corp.intel.com>
X-Mailer: Claws Mail 3.7.5 (GTK+ 2.18.7; i386-portbld-freebsd8.0)
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: "Kennedy, Brendan" <brendan.kennedy@intel.com>,
	"Philip@freebsd.org" <Philip@freebsd.org>
Subject: Re: [PATCH] patch to OpenCrypto framework
X-BeenThere: freebsd-drivers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Writing device drivers for FreeBSD <freebsd-drivers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-drivers>, 
	<mailto:freebsd-drivers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-drivers>
List-Post: <mailto:freebsd-drivers@freebsd.org>
List-Help: <mailto:freebsd-drivers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-drivers>,
	<mailto:freebsd-drivers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Feb 2010 21:52:29 -0000

Le Wed, 24 Feb 2010 16:50:35 +0000,
"Kennedy, Brendan" <brendan.kennedy@intel.com> a écrit :

> Hi Philip, All,

Hello,

> This OpenCrypto patch does a number of updates:
> 
> 1) It updates Cryptodev to allocate contiguous memory blocks – a
> requirement for some hardware drivers

I don't see the benefit for this one -changing malloc(9) to
contigmalloc(9)- it introduces a small (but useless) overhead
to existing drivers (I tried with glxsb : we lose around 5%).

IMO, if this is required for some drivers, this is not
the good place to do this. A crypto driver can receive data from
somewhere else than cryptodev: ipsec, geli, kerberos (at least)

Best regards.