From owner-freebsd-current@FreeBSD.ORG Wed Jan 5 20:26:24 2011 Return-Path: Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 80FAD106564A for ; Wed, 5 Jan 2011 20:26:24 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (lev.vlakno.cz [77.93.215.190]) by mx1.freebsd.org (Postfix) with ESMTP id 36AD38FC0C for ; Wed, 5 Jan 2011 20:26:23 +0000 (UTC) Received: from lev.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 6BE569CB42B; Wed, 5 Jan 2011 21:26:22 +0100 (CET) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by lev.vlakno.cz (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JweVgeK75tdm; Wed, 5 Jan 2011 21:26:21 +0100 (CET) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 9F3859CB492; Wed, 5 Jan 2011 21:26:21 +0100 (CET) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.14.4/8.14.4/Submit) id p05KQLUY095127; Wed, 5 Jan 2011 21:26:21 +0100 (CET) (envelope-from rdivacky) Date: Wed, 5 Jan 2011 21:26:21 +0100 From: Roman Divacky To: Erik Cederstrand Message-ID: <20110105202621.GA94901@freebsd.org> References: <20110105131439.GN23329@acme.spoerlein.net> <4184C8F2-3C6D-46FB-8F10-DDEBA6DB1C35@cederstrand.dk> <201101050934.49845.jhb@freebsd.org> <20110105165545.GP23329@acme.spoerlein.net> <1D4E1C30-82CB-4131-831F-EE3D167BACA2@cederstrand.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1D4E1C30-82CB-4131-831F-EE3D167BACA2@cederstrand.dk> User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@FreeBSD.ORG, Ulrich Sp?rlein Subject: Re: FYI: clang static analyzer page has moved to http://scan.freebsd.your.org/freebsd-head/ X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jan 2011 20:26:24 -0000 On Wed, Jan 05, 2011 at 09:22:42PM +0100, Erik Cederstrand wrote: > > Den 05/01/2011 kl. 17.55 skrev Ulrich Sp?rlein: > > > And clang did the right thing here in the past. Beware that it does no > > inter-procedural analysis yet, so it will usually miss that usage() > > calls exit unconditionally. > > > > *But*, it should grok that for err(3) and exit(3). Now there are some > > possible remedies: > > > > - get IPA to work with clang, or at least file a bug > > I filed a bug with LLVM (http://llvm.org/bugs/show_bug.cgi?id=8914) but it seems IPA bugs filed on the analyzer have been rejected in the past. I have a dumb patch that may help here... can someone test it? http://lev.vlakno.cz/~rdivacky/clang-checker-no-return.patch it may slow down the analysis a lot, if it does please add a recursion limit there... roman