From owner-freebsd-current Wed Nov 24 7:20:13 1999 Delivered-To: freebsd-current@freebsd.org Received: from relay.nuxi.com (nuxi.cs.ucdavis.edu [169.237.7.38]) by hub.freebsd.org (Postfix) with ESMTP id 142A315244 for ; Wed, 24 Nov 1999 07:20:07 -0800 (PST) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (root@d60-025.leach.ucdavis.edu [169.237.60.25]) by relay.nuxi.com (8.9.3/8.9.3) with ESMTP id HAA58191; Wed, 24 Nov 1999 07:19:46 -0800 (PST) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.9.3/8.9.1) id HAA77314; Wed, 24 Nov 1999 07:19:46 -0800 (PST) (envelope-from obrien) Date: Wed, 24 Nov 1999 07:19:46 -0800 From: "David O'Brien" To: John Hay Cc: current@FreeBSD.ORG Subject: Re: Overflow in banner(1) Message-ID: <19991124071946.G49362@dragon.nuxi.com> Reply-To: obrien@NUXI.com References: <199911240747.AAA18880@harmony.village.org> <199911240758.JAA96963@zibbi.mikom.csir.co.za> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0i In-Reply-To: <199911240758.JAA96963@zibbi.mikom.csir.co.za>; from jhay@mikom.csir.co.za on Wed, Nov 24, 1999 at 09:58:51AM +0200 X-Operating-System: FreeBSD 4.0-CURRENT Organization: The NUXI BSD group X-PGP-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Keyid: 34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Nov 24, 1999 at 09:58:51AM +0200, John Hay wrote: > Well the original line is plain wrong if Brian's patch is being used, > because there message is a pointer and the size of a pointer is 4. Yes, yes, yes. Warner and I are *not* that stupid WRT C. We were both commenting on the *original* proposed patch. Geez. Now rather than try to call us stupid, Kris (and only Kris) could say, "well, I've decided to go with a dynamically allocated buffer, so of course I can't use sizeof() any more". -- -- David (obrien@NUXI.com) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message