From owner-cvs-sys Tue Aug 1 17:15:24 1995 Return-Path: cvs-sys-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.11/8.6.6) id RAA16597 for cvs-sys-outgoing; Tue, 1 Aug 1995 17:15:24 -0700 Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.34]) by freefall.cdrom.com (8.6.11/8.6.6) with ESMTP id RAA16584 ; Tue, 1 Aug 1995 17:15:17 -0700 Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.9/8.6.9) id KAA09830; Wed, 2 Aug 1995 10:08:12 +1000 Date: Wed, 2 Aug 1995 10:08:12 +1000 From: Bruce Evans Message-Id: <199508020008.KAA09830@godzilla.zeta.org.au> To: CVS-commiters@freefall.cdrom.com, ache@freefall.cdrom.com, cvs-sys@freefall.cdrom.com Subject: Re: cvs commit: src/sys/kern tty.c tty_compat.c Sender: cvs-sys-owner@freebsd.org Precedence: bulk > Modified: sys/kern tty.c tty_compat.c > Log: > Check for valid speeds in TIOCSET* and return EINVAL for incorrect > values instead of setting garbadge. All speeds between 1 and LONG_MAX are valid. Some drivers support setting speeds that can't be handled by tty_compat. E.g., the cy driver allows 76800 and 150000 and many others. Handling these is a problem for tty_compat and crufty applications, not for the termios driver. All h/w tty drivers (except iitty :-() do their own speed checking. Perhaps the pty driver should only allow the standard speeds. Bruce