From owner-freebsd-ports@FreeBSD.ORG Sat Jan 22 15:13:23 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 70828106564A for ; Sat, 22 Jan 2011 15:13:23 +0000 (UTC) (envelope-from me@janh.de) Received: from mailhost.uni-hamburg.de (mailhost.uni-hamburg.de [134.100.32.155]) by mx1.freebsd.org (Postfix) with ESMTP id F13338FC19 for ; Sat, 22 Jan 2011 15:13:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mailhost.uni-hamburg.de (Postfix) with ESMTP id DC8C89009A; Sat, 22 Jan 2011 16:13:21 +0100 (CET) X-Virus-Scanned: by University of Hamburg (RRZ/mailhost) Received: from mailhost.uni-hamburg.de ([127.0.0.1]) by localhost (mailhost.uni-hamburg.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id GxrO5UQ98UJB; Sat, 22 Jan 2011 16:13:21 +0100 (CET) Received: from nb981.math (g224000199.adsl.alicedsl.de [92.224.0.199]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: fmjv004) by mailhost.uni-hamburg.de (Postfix) with ESMTPSA id 8FEC090008; Sat, 22 Jan 2011 16:13:21 +0100 (CET) Message-ID: <4D3AF40E.7090301@janh.de> Date: Sat, 22 Jan 2011 16:13:18 +0100 From: Jan Henrik Sylvester User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101219 Thunderbird/3.1.7 MIME-Version: 1.0 To: Chris Rees References: <4D39FEBA.3000806@janh.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: ports-list freebsd Subject: Re: Xournal: Please, help me with my first port X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Jan 2011 15:13:23 -0000 On 01/22/2011 14:04, Chris Rees wrote: > On 22 January 2011 12:53, Chris Rees wrote: >> On 21 January 2011 21:46, Jan Henrik Sylvester wrote: >>> Finally, I found an application worse having that is not in ports and looked >>> simple enough to try: Xournal is my first attempt to create a new port. >>> >>> I followed the handbook and did the basic testing with porttools: There are >>> warnings about considering to use DATADIR if the port was DATADIR-safe, but >>> I do not assume it to be. >>> >>> Moreover, there is a warning about my post-patch line. I think the warning >>> is wrong, but I am unsure about that line anyhow. The desktop-install target >>> in Makefile.in is wrong for FreeBSD, but there is probably a better way to >>> fix it. >>> >>> Is my attempt to use the desktop-install target via post-install correct? >>> >>> Do all the files installed by the post-install target go to the correct >>> locations? >>> >>> Is there anything else I should fix before submitting the port as pr? >>> >>> In case the attachment does not make it to the list, I have placed a copy >>> here: http://www.math.uni-hamburg.de/home/sylvester/xournal.shar >>> >> >> The DATADIR whines are addressed in this patch, have a look: >> >> http://www.bayofrum.net/~chris/patches/xournal-pkg-plist.diff Thanks, but since the port does not honor DATADIR, it should not be there -- or the DATADIR case must be fixed first. >> That's all I had time to look at at the moment, perhaps others can help! >> > > Alright, came back and now the patch has the desktop-install target > defined instead of using the post-install. This is reflected in the > patch linked above ^^^ Thanks, I was looking for something like that, but it should be "INSTALL_TARGET= install desktop-install", because desktop-install does not include install. > I've stuck it in my Tinderbox for testing, follow it here: > http://tinderbox.bayofrum.net/index.php?action=describe_port&id=196 Thanks! I do not know Tinderbox enough to understand, why your mkfontscale build tried to install an outdated version of freetype2. Cheers, Jan Henrik