Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Mar 2023 14:45:07 GMT
From:      Joseph Mingrone <jrm@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-branches@FreeBSD.org
Subject:   git: 4f66eb5be41f - 2023Q1 - multimedia/vlc: Turn off ASLR
Message-ID:  <202303101445.32AEj7tH021556@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch 2023Q1 has been updated by jrm:

URL: https://cgit.FreeBSD.org/ports/commit/?id=4f66eb5be41f75628d97511da21b78bf0a70b4a3

commit 4f66eb5be41f75628d97511da21b78bf0a70b4a3
Author:     Joseph Mingrone <jrm@FreeBSD.org>
AuthorDate: 2023-03-08 20:24:47 +0000
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2023-03-10 14:43:08 +0000

    multimedia/vlc: Turn off ASLR
    
    Starting with 13.2, elf processes will have ASLR turned on by default.
    However, the vlc binary core dumps with ASLR on, so turn it off until a
    proper fix can be found.
    
    This fix is based on a discussion between emaste and Peter
    <pmc@citylink.dinoex.sub.org>.
    
    See also:       https://lists.freebsd.org/archives/freebsd-stable/2023-March/001181.html
    PR:             270038
    
    Reviewed by:    emaste, mjg, riggs
    Approved by:    multimedia (tcberner, maintainer)
    Sponsored by:   The FreeBSD Foundation
    Differential Revision:  https://reviews.freebsd.org/D38994
    
    (cherry picked from commit 345272090c1216afd333c23a5b06494cb1961333)
---
 multimedia/vlc/Makefile | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/multimedia/vlc/Makefile b/multimedia/vlc/Makefile
index 4529d05caea5..121909074eab 100644
--- a/multimedia/vlc/Makefile
+++ b/multimedia/vlc/Makefile
@@ -1,5 +1,6 @@
 PORTNAME=	vlc
 DISTVERSION=	3.0.18
+PORTREVISION=	2
 PORTEPOCH=	4
 CATEGORIES=	multimedia audio net www
 MASTER_SITES=	http://download.videolan.org/pub/videolan/${PORTNAME}/${DISTVERSION:S/a$//}/ \
@@ -25,10 +26,12 @@ BUILD_DEPENDS=	gsed:textproc/gsed \
 		yasm:devel/yasm
 RUN_DEPENDS=	ffmpeg>=3.4.1,1:multimedia/ffmpeg
 
-USES=		compiler:c++17-lang cpe desktop-file-utils gettext-tools gmake gnome \
-		iconv:wchar_t libtool localbase pathfix pkgconfig tar:xz
+USES=		compiler:c++17-lang cpe desktop-file-utils elfctl gettext-tools \
+		gmake gnome iconv:wchar_t libtool localbase pathfix pkgconfig \
+		tar:xz
 
 CPE_VENDOR=	videolan
+ELF_FEATURES=	+noaslr:bin/.libs/vlc # See PR 270038
 
 # VLC git (post 2.2.4) requires C++11 support and passes the appropriate flag
 # to the compiler. Until the port is updated, we explicitly pass -std=c++11 to



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303101445.32AEj7tH021556>