From owner-cvs-src Wed Mar 12 4:30:47 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B529637B404; Wed, 12 Mar 2003 04:30:45 -0800 (PST) Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8273043FB1; Wed, 12 Mar 2003 04:30:39 -0800 (PST) (envelope-from bde@zeta.org.au) Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id XAA22479; Wed, 12 Mar 2003 23:30:37 +1100 Date: Wed, 12 Mar 2003 23:30:36 +1100 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: "Tim J. Robbins" Cc: src-committers@FreeBSD.org, "" , "" Subject: Re: cvs commit: src/sys/kern kern_resource.c In-Reply-To: <200303121124.h2CBOfQg069239@repoman.freebsd.org> Message-ID: <20030312231337.N29621@gamplex.bde.org> References: <200303121124.h2CBOfQg069239@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 12 Mar 2003, Tim J. Robbins wrote: > tjr 2003/03/12 03:24:41 PST > > FreeBSD src repository > > Modified files: > sys/kern kern_resource.c > Log: > Acquire sched_lock around use of FOREACH_KSEGRP_IN_PROC, accesses > to kg_nice and calls to sched_nice() in getpriority() and setpriority() > (really donice()). Locking for read access doesn't seem to be any more useful in getpriority() than anywhere else. Even when the value is used before the lock is released (in the loops), the value may become stale before it gets back to userland, and having a coherent set of values in the loops is not critical. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message