From owner-cvs-src@FreeBSD.ORG  Wed Feb  8 14:50:45 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6796D16A420;
	Wed,  8 Feb 2006 14:50:45 +0000 (GMT)
	(envelope-from dmitry@atlantis.dp.ua)
Received: from postman.atlantis.dp.ua (postman.atlantis.dp.ua [193.108.47.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 432C543D46;
	Wed,  8 Feb 2006 14:50:42 +0000 (GMT)
	(envelope-from dmitry@atlantis.dp.ua)
Received: from smtp.atlantis.dp.ua (smtp.atlantis.dp.ua [193.108.46.231])
	by postman.atlantis.dp.ua (8.13.1/8.13.1) with ESMTP id k18EoNtI017091; 
	Wed, 8 Feb 2006 16:50:23 +0200 (EET)
	(envelope-from dmitry@atlantis.dp.ua)
Date: Wed, 8 Feb 2006 16:50:23 +0200 (EET)
From: Dmitry Pryanishnikov <dmitry@atlantis.dp.ua>
To: "George V. Neville-Neil" <gnn@FreeBSD.org>
Message-ID: <20060208164330.M6453@atlantis.atlantis.dp.ua>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/netinet6 in6.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Feb 2006 14:50:45 -0000



Hello!

> Date:      Wed, 8 Feb 2006 07:16:46 +0000 (UTC)
> From:      "George V. Neville-Neil" <gnn@FreeBSD.org>
>
> gnn         2006-02-08 07:16:46 UTC
>
>  FreeBSD src repository
>
>  Modified files:
>    sys/netinet6         in6.c
>  Log:
>  Fix for an inappropriate bzero of the ICMPv6 stats.  The code was zero'ing 
> the wrong structure member but setting the correct one.

     Now we have the following code here:

   bzero(&ifr->ifr_ifru.ifru_icmp6stat,
           sizeof(ifr->ifr_ifru.ifru_icmp6stat));
   ifr->ifr_ifru.ifru_icmp6stat =
           *((struct in6_ifextra *)ifp->if_afdata[AF_INET6])->icmp6_ifstat;

I don't understand what's the point of bzero()'ing this object (struct 
in6_ifextra, as I see) just before assignment? Doesn't the second statement
overwrite _all significant_ result of the first one?

Sincerely, Dmitry
-- 
Atlantis ISP, System Administrator
e-mail:  dmitry@atlantis.dp.ua
nic-hdl: LYNX-RIPE