From owner-cvs-share Fri Aug 23 00:26:25 1996 Return-Path: owner-cvs-share Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id AAA03543 for cvs-share-outgoing; Fri, 23 Aug 1996 00:26:25 -0700 (PDT) Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id AAA03363; Fri, 23 Aug 1996 00:21:51 -0700 (PDT) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id JAA04619; Fri, 23 Aug 1996 09:21:18 +0200 Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id JAA17840; Fri, 23 Aug 1996 09:21:18 +0200 Received: (from j@localhost) by uriah.heep.sax.de (8.7.5/8.6.9) id JAA29339; Fri, 23 Aug 1996 09:10:01 +0200 (MET DST) From: J Wunsch Message-Id: <199608230710.JAA29339@uriah.heep.sax.de> Subject: Re: cvs commit: src/share/man/man9 style.9 To: mpp@freefall.freebsd.org (Mike Pritchard) Date: Fri, 23 Aug 1996 09:10:01 +0200 (MET DST) Cc: wosch@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-share@freefall.freebsd.org Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch) In-Reply-To: <199608222027.NAA14699@freefall.freebsd.org> from Mike Pritchard at "Aug 22, 96 01:27:59 pm" X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E X-Mailer: ELM [version 2.4ME+ PL17 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-share@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk As Mike Pritchard wrote: > > remove case '?', if '?' is not in getopt(), it should > > not be in the switch statement > '?' is a valid return value from getopt(), and should probably be > in the switch statement, even if it is covered by the "default" case. > Since this is the style guide, including it in the example will > at least make people think about it. Yep. Folks, please discuss modifications to the style guide first. -- cheers, J"org joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-)