From owner-freebsd-ports@FreeBSD.ORG Thu Jun 13 17:50:10 2013 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 07F85523 for ; Thu, 13 Jun 2013 17:50:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wg0-x230.google.com (mail-wg0-x230.google.com [IPv6:2a00:1450:400c:c00::230]) by mx1.freebsd.org (Postfix) with ESMTP id 944BC1A44 for ; Thu, 13 Jun 2013 17:50:09 +0000 (UTC) Received: by mail-wg0-f48.google.com with SMTP id f11so376873wgh.27 for ; Thu, 13 Jun 2013 10:50:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=QyllTABNKsvE4AMypE3+/bBIVkfwOR8zvUsX/vJ0gms=; b=Mtsv82Vw4ksBRHRXeGUe8YzFuSqMeafL3IMYV/NCEdM4hzI0wTaOZZx9neTVeyKAaf lYD8hF0KbJNPT8AKB6lH/1q8/s1pXY5HoGzOwjvHblEbf/PvEBHg7yVUHDibnj0N96Z8 PmRN2Can/pOwzlIzRilxybgjfyOToVpc0XaQ9CeWxMNB4lJ2F3/OY5VXh5CJxbyXLszO bApYoIyvuiSjtOu5NVZ3Z/w5BesyGhymX8abdD6zSh2qiINOm5wjzHhEKImMJQdyasqa UWuMLf6+ZaedPSgwy8GLX1I7w/adEwdvkoq45XU7vZSm7HKhOV5fnJ1dzB88g6DLtb5U BR1A== X-Received: by 10.180.39.233 with SMTP id s9mr1222759wik.25.1371145808753; Thu, 13 Jun 2013 10:50:08 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id r9sm11726959wik.1.2013.06.13.10.50.07 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 13 Jun 2013 10:50:07 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 13 Jun 2013 19:50:05 +0200 From: Baptiste Daroussin To: olli hauer Subject: Re: [CFT] Fixing/changing LIB_DEPENDS Message-ID: <20130613175005.GC44980@ithaqua.etoilebsd.net> References: <20130613130730.GK99460@ithaqua.etoilebsd.net> <51B9FA28.3020303@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5G06lTa6Jq83wMTw" Content-Disposition: inline In-Reply-To: <51B9FA28.3020303@gmx.de> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: ports@FreeBSD.org X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jun 2013 17:50:10 -0000 --5G06lTa6Jq83wMTw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 13, 2013 at 06:58:16PM +0200, olli hauer wrote: > On 2013-06-13 15:07, Baptiste Daroussin wrote: > > Hi, > >=20 > > Here is a patch to fix LIB_DEPENDS. > >=20 > > First what is/are the problem of LIB_DEPENDS. > >=20 > > LIB_DEPENDS relies on of ldconfig -r to get its valid or not installed = shared > > libraries, problem is: > > liba-5.2.so and liba-5.so.2 will both be a-5.2 for ldconfig -r, which i= s not > > really what we want. > >=20 > > secondly ldconfig -r is only able to print something for libraries in t= he form > > of: lib.so[.number], while we have no technical limitation to enf= orce this > > form and it is more and more common to find libraries in the following = form: > > lib.so.major.minor.patch and to get them working properly right k= now we > > have to patch the upstream build system, to send some magic tricks on l= ibtool > > etc, all that kind of things all of us loves to deal with. > >=20 > > What I do propose is a new form of LIB_DEPENDS in addition to the curre= nt one: > > LIB_DEPENDS=3D bla.so[numberwithlongorwhatever]:${PORTSDIR}/cat/bla > >=20 > > What the framework will do, is lookup in all libraries directories for > > libbla.so[numberwithdotsorwhatever] test if it exists (test -f also val= idate the > > symlink is pointing to a regular file) if /usr/bin/file is present on y= our > > system it will validate the pointed file is really a shared library. > >=20 > > Any review welcome: http://people.freebsd.org/~bapt/fix-libdepends.patch > >=20 > > This idea behind this patch is on mid/long term to remove the other LIB= _DEPENDS > > forms. > >=20 > > I do plan to commit this on next friday 2013-06-21. > >=20 > > regards, > > Bapt > >=20 >=20 >=20 >=20 > Hm, >=20 > so this is a modern extended incarnation of the old LIB_DEPENDS notation > For example pcre.3:... becomes pcre:... >=20 > Isn't this something that can be handled with some additional code in pat= hfix? >=20 > -- > regards, > olli >=20 Either I m missing something, or I don't see the point about pathfix. It is not a matter of path, but rather allowing the ports tree to handle properly all kind of library name, right now we have some false limitation = and library name collision because we wrongly rely on ldconfig -r. we have lots of patches so convert library names to a format libname.so.asinglenumber, just for the sake of a technical limitation of the ports tree. That is what I m trying to fix. regards, Bapt --5G06lTa6Jq83wMTw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlG6Bk0ACgkQ8kTtMUmk6ExYnwCbBdUrMFDKtgrmFoKWX94jI1DH V7QAnAiCHqQvODGWvv4qrX3UvFU93fkP =/3Mi -----END PGP SIGNATURE----- --5G06lTa6Jq83wMTw--