From owner-cvs-src@FreeBSD.ORG Fri Jan 11 01:41:47 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 513F716A521 for ; Fri, 11 Jan 2008 01:41:47 +0000 (UTC) (envelope-from peter@wemm.org) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.153]) by mx1.freebsd.org (Postfix) with ESMTP id 0BC4F13C46E for ; Fri, 11 Jan 2008 01:41:46 +0000 (UTC) (envelope-from peter@wemm.org) Received: by fg-out-1718.google.com with SMTP id 16so962181fgg.35 for ; Thu, 10 Jan 2008 17:41:45 -0800 (PST) Received: by 10.82.186.5 with SMTP id j5mr4392239buf.16.1200015705126; Thu, 10 Jan 2008 17:41:45 -0800 (PST) Received: by 10.82.181.17 with HTTP; Thu, 10 Jan 2008 17:41:45 -0800 (PST) Message-ID: Date: Thu, 10 Jan 2008 17:41:45 -0800 From: "Peter Wemm" To: "Alfred Perlstein" In-Reply-To: <20080111010033.GC52842@elvis.mu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200801102336.m0ANa0mP035046@repoman.freebsd.org> <20080111010033.GC52842@elvis.mu.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/nfsclient nfs_socket.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Jan 2008 01:41:47 -0000 On Jan 10, 2008 5:00 PM, Alfred Perlstein wrote: > > * John Baldwin [080110 15:33] wrote: > > jhb 2008-01-10 23:36:00 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/nfsclient nfs_socket.c > > Log: > > Pass curthread to various socket routines (socreate(), sobind(), and > > soconnect()) instead of &thread0 when establishing a connection to the NFS > > server. Otherwise inconsistent credentials may be used when setting up > > the NFS socket. > > I'm not sure, but I think this may be a regression, I seem to recall > that a long time ago it was switched to &thread0 because otherwise > certain operations can fail due to curthread not running as root. That's my recollection too. For example, when nfs is configured to bind to a priviliged local port for making queries or connections, it had to be done as root. With tcp mounts, the connection can be dropped and a reconnect required at any time. -- Peter Wemm - peter@wemm.org; peter@FreeBSD.org; peter@yahoo-inc.com "All of this is for nothing if we don't go to the stars" - JMS/B5