From owner-svn-src-all@FreeBSD.ORG Tue Oct 27 21:28:55 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F0A5106566B; Tue, 27 Oct 2009 21:28:55 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.159]) by mx1.freebsd.org (Postfix) with ESMTP id C27A38FC0A; Tue, 27 Oct 2009 21:28:54 +0000 (UTC) Received: by fg-out-1718.google.com with SMTP id d23so114175fga.13 for ; Tue, 27 Oct 2009 14:28:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=2yCJzr4T8BIybonudztHoIUWhygWgmGfmLThgfrnnWU=; b=vAu8qRHRySdJQcKD10m9zhmokckzKBBin69sbEVfP1R+fuV5x7omAsprq3AvX9dJRO UuIPN6j4dLLu3cVB1TmbiNzkCUkKSuK/cTJZc6SQKPJW1bZyod++UJQECMT3HRoWwK92 eke0/ALfzqn1wTT7IvKjO8JvwhHJuSHaXD+RI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=ts9oAiu4TOeZCyCq0QZBIYQ0xnN3k4UNv+l901WfVmNNVgbwOziCnyDVbcjsm7X5u7 f8NWA3PmS+s8ZRLDX3PRQY3BXrSO4cLtZXVanWl4D6cFYu65f3XiJffk5BFI4FdmdFs7 +0d9g5vFlJKigqBhGvg/TrwQCLPBk2qQZpYyw= Received: by 10.102.197.14 with SMTP id u14mr6917388muf.39.1256678933583; Tue, 27 Oct 2009 14:28:53 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id 23sm1679194mum.14.2009.10.27.14.28.52 (version=SSLv3 cipher=RC4-MD5); Tue, 27 Oct 2009 14:28:52 -0700 (PDT) Sender: Alexander Motin Message-ID: <4AE76611.4030104@FreeBSD.org> Date: Tue, 27 Oct 2009 23:28:49 +0200 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20090901) MIME-Version: 1.0 To: "M. Warner Losh" References: <200910261123.n9QBNfJY087028@svn.freebsd.org> <20091027.150719.-1219478921.imp@bsdimp.com> In-Reply-To: <20091027.150719.-1219478921.imp@bsdimp.com> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r198487 - head/sys/dev/ata X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Oct 2009 21:28:55 -0000 M. Warner Losh wrote: > In message: <200910261123.n9QBNfJY087028@svn.freebsd.org> > Alexander Motin writes: > : Author: mav > : Date: Mon Oct 26 11:23:41 2009 > : New Revision: 198487 > : URL: http://svn.freebsd.org/changeset/base/198487 > : > : Log: > : Round timeout up when converting CAM milliseconds to ATA seconds. > > This implements ceil(timeout) rather than round(timeout). Is that > intended? Yes. It is better to turn 400ms to 1s rather then 0. Usually timeouts aren't so short to make it important, but I have seen such case once, so it is possible to predict another. -- Alexander Motin