From owner-cvs-all@FreeBSD.ORG  Sun May 27 17:14:34 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 9FACF16A4CB;
	Sun, 27 May 2007 17:14:34 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 90BCA13C48A;
	Sun, 27 May 2007 17:14:34 +0000 (UTC)
	(envelope-from rwatson@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l4RHEYxa018285;
	Sun, 27 May 2007 17:14:34 GMT
	(envelope-from rwatson@repoman.freebsd.org)
Received: (from rwatson@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l4RHEYOr018283;
	Sun, 27 May 2007 17:14:34 GMT (envelope-from rwatson)
Message-Id: <200705271714.l4RHEYOr018283@repoman.freebsd.org>
From: Robert Watson <rwatson@FreeBSD.org>
Date: Sun, 27 May 2007 17:14:34 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Cc: 
Subject: cvs commit: src/sys/netncp ncp_conn.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 May 2007 17:14:34 -0000

rwatson     2007-05-27 17:14:34 UTC

  FreeBSD src repository

  Modified files:
    sys/netncp           ncp_conn.c 
  Log:
  In ncp_conn_alloc(), a new credential pointer, 'owner', is set up to point
  at the credential to be used by the connection.  However, the pointer's
  value was ignored when actually setting hcp->nc_owner.
  
  (1) Do set nc_owner to the owner pointer value so that the credential is
      not discarded after being carefully configured.
  
  (2) In the case where we create a new credential with modified uid, copy
      the existing credential to initialize non-uid fields to existing
      values, which will lead to a fully initialized MAC label, groups, etc.
  
  Found with:     Coverity Prevent(tm)
  CID:            2226
  
  Revision  Changes    Path
  1.30      +4 -3      src/sys/netncp/ncp_conn.c