From owner-freebsd-current  Wed Jun 21 20:56:53 2000
Delivered-To: freebsd-current@freebsd.org
Received: from assaris.sics.se (assaris.sics.se [193.10.66.234])
	by hub.freebsd.org (Postfix) with ESMTP
	id 096A737C14B; Wed, 21 Jun 2000 20:56:49 -0700 (PDT)
	(envelope-from assar@assaris.sics.se)
Received: (from assar@localhost)
	by assaris.sics.se (8.9.3/8.9.3) id FAA05022;
	Thu, 22 Jun 2000 05:57:02 +0200 (CEST)
	(envelope-from assar)
To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu>
Cc: current@FreeBSD.ORG, kris@FreeBSD.ORG
Subject: Re: vnode_if.h: how should it be done ?
References: <5ln1kesdkq.fsf@assaris.sics.se> <200006220345.XAA42447@khavrinen.lcs.mit.edu>
From: Assar Westerlund <assar@sics.se>
Date: 22 Jun 2000 05:57:01 +0200
In-Reply-To: Garrett Wollman's message of "Wed, 21 Jun 2000 23:45:27 -0400 (EDT)"
Message-ID: <5llmzyqsfm.fsf@assaris.sics.se>
Lines: 65
User-Agent: Gnus/5.070098 (Pterodactyl Gnus v0.98) Emacs/20.7
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Garrett Wollman <wollman@khavrinen.lcs.mit.edu> writes:

> <<On 22 Jun 2000 03:35:01 +0200, Assar Westerlund <assar@sics.se> said:
> 
> > So I propose the patch below, to create vnode_if.h and then add it to CVS.
> 
> There are too many generated files in CVS as it is.
> 
> If there is a problem here, the correct fix is to supply the source
> files, not the generated output.

The problem is that the source files are hidden in the kernel source
directory and not installed.  Where should vnode_if.{src,pl} get
installed?  It seems much simpler just to install vnode_if.h in
/usr/include/sys.  Patch appended.

/assar

Index: Makefile
===================================================================
RCS file: /home/ncvs/src/include/Makefile,v
retrieving revision 1.113
diff -u -w -r1.113 Makefile
--- Makefile	2000/05/19 22:08:18	1.113
+++ Makefile	2000/06/22 03:55:52
@@ -6,7 +6,7 @@
 # The ``rm -rf''s used below are safe because rm doesn't follow symbolic
 # links.
 
-CLEANFILES= osreldate.h version vers.c
+CLEANFILES= osreldate.h version vers.c vnode_if.h
 SUBDIR= rpcsvc
 FILES=	a.out.h ar.h assert.h bitstring.h ctype.h db.h dirent.h disktab.h \
 	dlfcn.h elf.h err.h fnmatch.h fstab.h \
@@ -57,7 +57,7 @@
 #SHARED=	symlinks
 SHARED?=	copies
 
-all:	osreldate.h
+all:	osreldate.h vnode_if.h
 
 osreldate.h:	${.CURDIR}/../sys/conf/newvers.sh \
 		${.CURDIR}/../sys/sys/param.h
@@ -68,6 +68,11 @@
 	echo \#'undef __FreeBSD_version' >> osreldate.h;	\
 	echo \#'define __FreeBSD_version' $$RELDATE >> osreldate.h
 
+vnode_if.h:	${.CURDIR}/../sys/kern/vnode_if.pl \
+		${.CURDIR}/../sys/kern/vnode_if.src
+	@${ECHO} creating vnode_if.h
+	perl ${.CURDIR}/../sys/kern/vnode_if.pl -h ${.CURDIR}/../sys/kern/vnode_if.src
+
 beforeinstall: ${SHARED}
 	@rm -f ${DESTDIR}/usr/include/timepps.h
 	cd ${.CURDIR}; \
@@ -85,6 +90,9 @@
 	${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \
 		${.OBJDIR}/osreldate.h \
 		${DESTDIR}/usr/include
+	${INSTALL} -C -o ${BINOWN} -g ${BINGRP} -m 444 \
+		${.OBJDIR}/vnode_if.h \
+		${DESTDIR}/usr/include/sys
 .for i in ${LFILES}
 	ln -sf sys/$i ${DESTDIR}/usr/include/$i
 .endfor


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message