From owner-freebsd-audit Tue Dec 17 13:57:59 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A1B8F37B401; Tue, 17 Dec 2002 13:57:57 -0800 (PST) Received: from relay1.intelsat.com (relay1.intelsat.com [164.86.102.13]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF18343EDA; Tue, 17 Dec 2002 13:57:56 -0800 (PST) (envelope-from Michael.Hughes@Intelsat.com) Received: from mailm.adm.intelsat.int ([164.86.32.118]) by relay1.intelsat.com (Post.Office MTA v3.1.2 release (PO203-101c) ID# 0-0U10L2S100) with ESMTP id AAA2814; Tue, 17 Dec 2002 16:54:23 -0500 Received: from admex3.adm.intelsat.int (not verified[164.86.33.21]) by mailm.adm.intelsat.int with MailMarshal (4,2,5,0) id ; Tue, 17 Dec 2002 16:57:49 -0500 Received: by admex3.adm.intelsat.int with Internet Mail Service (5.5.2653.19) id ; Tue, 17 Dec 2002 17:08:15 -0500 Message-ID: From: Michael.Hughes@Intelsat.com To: thomas@freebsd.org, freebsd-audit@freebsd.org Subject: RE: RELENG_4 loader bug Date: Tue, 17 Dec 2002 16:49:37 -0500 MIME-Version: 1.0 X-Mailer: Internet Mail Service (5.5.2653.19) Content-Type: text/plain Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Pls take "michael.hughes@intelsat.com" off your distribution. thanks -----Original Message----- From: Thomas Quinot [mailto:thomas@freebsd.org] Sent: Tuesday, 17 December, 2002 4:25 PM To: freebsd-audit@freebsd.org Subject: RELENG_4 loader bug Dear -audit folks, Could you please review this patch to the RELENG_4 loader? It fixes kern/46275 (this bug is specific to -stable, I was unable to reproduce it with -current). When the last module in a dependency chain fails to load with EEXIST, an error of 0 must be returned to the caller, or else the whole set of newly-loaded modules will be discarded. Index: module.c =================================================================== RCS file: /home/ncvs/src/sys/boot/common/module.c,v retrieving revision 1.13.2.3 diff -u -r1.13.2.3 module.c --- module.c 12 Jun 2001 15:35:14 -0000 1.13.2.3 +++ module.c 15 Dec 2002 15:09:07 -0000 @@ -369,7 +369,9 @@ if (mod_findmodule(NULL, dmodname) == NULL) { printf("loading required module '%s'\n", dmodname); error = mod_load(dmodname, 0, NULL); - if (error && error != EEXIST) + if (error == EEXIST) + error = 0; + if (error != 0) break; } md = metadata_next(md, MODINFOMD_DEPLIST); -- Thomas.Quinot@Cuivre.FR.EU.ORG To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message ############################################################ This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message. Any views expressed in this message are those of the individual sender, except where the sender specifically states them to be the views of Intelsat, Ltd. and its subsidiaries. ############################################################ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message