From owner-freebsd-hackers@FreeBSD.ORG  Tue Aug  3 13:57:16 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 31ABB1065675
	for <freebsd-hackers@freebsd.org>; Tue,  3 Aug 2010 13:57:16 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id 043898FC12
	for <freebsd-hackers@freebsd.org>; Tue,  3 Aug 2010 13:57:16 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id B181746B90;
	Tue,  3 Aug 2010 09:57:15 -0400 (EDT)
Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id A8E3C8A04F;
	Tue,  3 Aug 2010 09:57:14 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-hackers@freebsd.org
Date: Tue, 3 Aug 2010 09:44:00 -0400
User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100217; KDE/4.4.5; amd64; ; )
References: <AANLkTikMFhG1QLDf4raf+rxOKhobjoA-dRbUew2-8KeF@mail.gmail.com>
In-Reply-To: <AANLkTikMFhG1QLDf4raf+rxOKhobjoA-dRbUew2-8KeF@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201008030944.01011.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Tue, 03 Aug 2010 09:57:14 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham
	version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: Oleg Sharoyko <osharoiko@gmail.com>
Subject: Re: PCI config space is not restored upon resume (macbook pro)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Aug 2010 13:57:16 -0000

On Tuesday, August 03, 2010 6:49:07 am Oleg Sharoyko wrote:
> Hi!
> 
> I'm trying to make FreeBSD (9-Current, checkout on 2010-08-01) correctly
> suspend/resume on macbook pro. As of now I have to issues with resume:
> 
> 1. Display stays blank upon resume. Got 'vga0: failed to reload state'
>  in dmesg, but I haven't looked into this  yet.
> 
> 2. Some hardware is missing upon resume, specifically ath, msk and firewire.
> This devices disappear because rather strange values are being
> read from pci config space (such as vendor id, device id and others).

I wonder if the bus numbers for PCI-PCI bridges need to be restored on resume?  
If they aren't then config transactions won't be routed properly.  You could 
add a pcib_resume() method that prints out the various bus register values 
after resume to see if they match what we print out during boot.

-- 
John Baldwin