From owner-svn-src-user@FreeBSD.ORG Thu Mar 7 23:37:10 2013 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id EAAEAFD4; Thu, 7 Mar 2013 23:37:10 +0000 (UTC) (envelope-from attilio@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id BB055ABB; Thu, 7 Mar 2013 23:37:10 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.6/8.14.6) with ESMTP id r27NbAmC055522; Thu, 7 Mar 2013 23:37:10 GMT (envelope-from attilio@svn.freebsd.org) Received: (from attilio@localhost) by svn.freebsd.org (8.14.6/8.14.5/Submit) id r27NbAqn055520; Thu, 7 Mar 2013 23:37:10 GMT (envelope-from attilio@svn.freebsd.org) Message-Id: <201303072337.r27NbAqn055520@svn.freebsd.org> From: Attilio Rao Date: Thu, 7 Mar 2013 23:37:10 +0000 (UTC) To: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: svn commit: r247969 - user/attilio/vmc-playground/sys/vm X-SVN-Group: user MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2013 23:37:11 -0000 Author: attilio Date: Thu Mar 7 23:37:10 2013 New Revision: 247969 URL: http://svnweb.freebsd.org/changeset/base/247969 Log: Improve comments. Sponsored by: EMC / Isilon storage division Submitted by: mdf Modified: user/attilio/vmc-playground/sys/vm/vm_radix.c Modified: user/attilio/vmc-playground/sys/vm/vm_radix.c ============================================================================== --- user/attilio/vmc-playground/sys/vm/vm_radix.c Thu Mar 7 23:35:06 2013 (r247968) +++ user/attilio/vmc-playground/sys/vm/vm_radix.c Thu Mar 7 23:37:10 2013 (r247969) @@ -35,10 +35,10 @@ * of this code must achieve highest possible performance. * * The implementation takes into account the following rationale: - * - Size of the nodes might be as small as possible. + * - Size of the nodes should be as small as possible. * - There is no bias toward lookup operations over inserts or removes, * and vice-versa. - * - In average there are not many complete levels, than level + * - On average not many nodes are expected to be full, hence level * compression may just complicate things. */ @@ -222,7 +222,7 @@ vm_radix_keydiff(vm_pindex_t index1, vm_ for (clev = 0; clev <= VM_RADIX_LIMIT ; clev++) if (vm_radix_slot(index1, clev)) return (clev); - panic("%s: it might have not reached this point", __func__); + panic("%s: cannot reach this point", __func__); return (0); } @@ -508,9 +508,9 @@ restart: * available bisection node, or to the smaller value * in the current domain (if the owner is bigger than the * search key). - * The search for a valid bisection node is helped through - * the use of maplevels array which should bring immediately - * a lower useful level, skipping holes. + * The maplevels array records any node has been seen + * at a given level. This aids the search for a valid + * bisection node. */ if (vm_radix_keybarr(rnode, index)) { difflev = vm_radix_keydiff(index, rnode->rn_owner); @@ -597,9 +597,9 @@ restart: * available bisection node, or to the higher value * in the current domain (if the owner is smaller than the * search key). - * The search for a valid bisection node is helped through - * the use of maplevels array which should bring immediately - * a lower useful level, skipping holes. + * The maplevels array records any node has been seen + * at a given level. This aids the search for a valid + * bisection node. */ if (vm_radix_keybarr(rnode, index)) { difflev = vm_radix_keydiff(index, rnode->rn_owner);