From owner-svn-src-head@freebsd.org Mon Nov 21 19:50:37 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 105C6C4DEB6 for ; Mon, 21 Nov 2016 19:50:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x231.google.com (mail-it0-x231.google.com [IPv6:2607:f8b0:4001:c0b::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CD7841842 for ; Mon, 21 Nov 2016 19:50:36 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x231.google.com with SMTP id c20so405244itb.0 for ; Mon, 21 Nov 2016 11:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=MzVYMt/CTYEisqV4FB3W+JZAO/qtlqRwsj5KgAv+6jk=; b=IAOlAPPdKNwndAWjTqQr6bkODW+nXt9L5YG5WdUgCUPFxa5M7BBFCCKu4AsrFUSR0R W0QJWf+xZMQM0niIQRtYHWXJXvrz71kJZNckvXXwrC/dzBvGtz5I87krwVw+dXxYQmtF D7T72kggDedAwhXRLsKSUpqTGsaRe6RB/N8f+OIdIUznxb/RZ7ZfQs8phxkKmj3yJHRf xXshfPfsK4sNbWITQ009py2bw7TfFOX09Uehl0g0VxePaJWReqTSC5NmN0gLqhPrja1H DQ0jjG35JrYHNjRIW5F1Hr1RxTq1eQcJoBQtI4jwQJGRhe2qk30wEdQetqxysOuJhOaZ 454w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=MzVYMt/CTYEisqV4FB3W+JZAO/qtlqRwsj5KgAv+6jk=; b=bYfuvns4COqMR2ALDaxBH0CFQjGs5CuuTx2I/1RT7ZVE1BQZ5rT7QL3zfj3hk6WGbg /PuGtGhjCfY5KDs9ORqA1+qft4UsKduQzTee19LKbU4CgkiTXpt6A4lo7e/3Til3kGc9 2/DPi/fhI0gD5cHnj0ioO7hWJ7quwG+1I7T66p1M3EZguP3lqoplf/QngERZVEOhs42n Zo5r2KJdw2Q0dUhgs7UM8l8TO1hakiJvuGSNuPEkxCbwKtJsU1pqIKDxWOkZ4zHlcsZH IMRviK/mHy+CyHlt2gVcHuGh+5p5Q2t/5b43tPKDbsJbOcponDqUR2chubJ/GBKPmVC+ nREw== X-Gm-Message-State: AKaTC03J2sKPdgVFvgDCrQw1g1uXxAXClQ0zTatOExmh65H82SrGFXHaHza0ugY1Dyaoota2jyP1rOKv2bSOlg== X-Received: by 10.36.5.208 with SMTP id 199mr10806521itl.103.1479757836189; Mon, 21 Nov 2016 11:50:36 -0800 (PST) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.134.66 with HTTP; Mon, 21 Nov 2016 11:50:35 -0800 (PST) X-Originating-IP: [69.53.245.200] In-Reply-To: <123365400.XYmKG93e4H@ralph.baldwin.cx> References: <201611192146.uAJLkDP5094317@repo.freebsd.org> <123365400.XYmKG93e4H@ralph.baldwin.cx> From: Warner Losh Date: Mon, 21 Nov 2016 12:50:35 -0700 X-Google-Sender-Auth: 0wTj0FXnCHw2JDsOjh3rsbFNyv0 Message-ID: Subject: Re: svn commit: r308869 - head/sbin/nvmecontrol To: John Baldwin Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 19:50:37 -0000 On Mon, Nov 21, 2016 at 11:07 AM, John Baldwin wrote: > On Saturday, November 19, 2016 09:46:13 PM Warner Losh wrote: >> Author: imp >> Date: Sat Nov 19 21:46:13 2016 >> New Revision: 308869 >> URL: https://svnweb.freebsd.org/changeset/base/308869 >> >> Log: >> i386 turns out to not have __uint128_t. So confusingly use 64-bit math >> instead. Since we're little endian, we can get away with it. Also, >> since the counters in quesitons would require billions of iops for >> tens of billions of seconds to overflow, and since such data rates are >> unlikely for people using i386 for a while, that's OK. The fastest >> cards today can't do even a million IOPs. >> >> Noticed by: dim@ >> Sponsored by: Netflix, Inc > > It probably has it if you compile with -march= where is new > enough to have SSE. Yea, but this solution was good enough... There's also a lot of issues with 128bit ints in different versions of gcc and I didn't want to play the whack-a-mole game, so I punted. > Is nvme inherently x86-only? No. However, the implementation was done by Intel, only tested on x86 and has known issues with endian-ness. So we build only on x86. Warner