From owner-p4-releng Tue Apr 2 14:28:16 2002 Delivered-To: p4-releng@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id D9FAE37B400; Tue, 2 Apr 2002 14:28:09 -0800 (PST) Delivered-To: perforce@freebsd.org Received: from rwcrmhc54.attbi.com (rwcrmhc54.attbi.com [216.148.227.87]) by hub.freebsd.org (Postfix) with ESMTP id 92F1337B405; Tue, 2 Apr 2002 14:28:08 -0800 (PST) Received: from bmah.dyndns.org ([12.233.149.189]) by rwcrmhc54.attbi.com (InterMail vM.4.01.03.27 201-229-121-127-20010626) with ESMTP id <20020402222808.LNWY15826.rwcrmhc54.attbi.com@bmah.dyndns.org>; Tue, 2 Apr 2002 22:28:08 +0000 Received: from intruder.bmah.org (localhost [IPv6:::1]) by bmah.dyndns.org (8.12.2/8.12.2) with ESMTP id g32MS8d8039656; Tue, 2 Apr 2002 14:28:08 -0800 (PST) (envelope-from bmah@intruder.bmah.org) Received: (from bmah@localhost) by intruder.bmah.org (8.12.2/8.12.2/Submit) id g32MS8VB039655; Tue, 2 Apr 2002 14:28:08 -0800 (PST) Message-Id: <200204022228.g32MS8VB039655@intruder.bmah.org> To: obrien@FreeBSD.org Cc: "Bruce A. Mah" , Perforce Change Reviews Subject: Re: PERFORCE change 8929 for review In-reply-to: <20020402140528.A48987@dragon.nuxi.com> References: <200204022153.g32LrnQ29689@freefall.freebsd.org> <20020402140528.A48987@dragon.nuxi.com> Comments: In-reply-to "David O'Brien" message dated "Tue, 02 Apr 2002 14:05:28 -0800." From: bmah@FreeBSD.org Reply-To: bmah@FreeBSD.org X-Face: g~c`.{#4q0"(V*b#g[i~rXgm*w;:nMfz%_RZLma)UgGN&=j`5vXoU^@n5v4:OO)c["!w)nD/!!~e4Sj7LiT'6*wZ83454H""lb{CC%T37O!!'S$S&D}sem7I[A 2V%N&+ X-Image-Url: http://www.employees.org/~bmah/Images/bmah-cisco-small.gif X-Url: http://www.employees.org/~bmah/ Date: Tue, 02 Apr 2002 14:28:08 -0800 Sender: owner-p4-releng@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG If memory serves me right, "David O'Brien" wrote: > On Tue, Apr 02, 2002 at 01:53:49PM -0800, Bruce A. Mah wrote: > > http://people.freebsd.org/~peter/p4db/chv.cgi?CH=8929 > > > > Change 8929 by bmah@bmah_intruder on 2002/04/02 13:52:50 > > > > Don't make the assumption that source files are writable. > > The FDP infrastructure has a few constructs of the form > > "cp foo bar; cat baz >> bar". This breaks if foo isn't > > writable (as is frequently the case in P4 work directory). > > > > I'm not sure if this change should be made in CVS or not, > > and if so, if this is exactly the right change. In the meantime, > > we've at least unbroken doc builds out of P4 work areas. > > It should, otherwise we break assumptions of read-only sources. The problem here was not that we actually tried to modify any of the source files. In that sense, the old infrastructure always worked with read-only sources. The difficulty was the assumption that if you made a copy of a source file, the permission bits on the copy would allow you to write/append to it. Files in a P4 work area can violate this assumption because they have read-only filesystem permissions until you do a "p4 edit". In any case, I want to ponder this a bit more before deciding whether this is the change we want to commit "for real" to CVS, or if we should do some variant of this. Thanks, Bruce. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-releng" in the body of the message