From nobody Tue Apr 30 07:07:25 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VTB8t2Pq3z5JN10; Tue, 30 Apr 2024 07:07:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VTB8t0Prnz593j; Tue, 30 Apr 2024 07:07:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714460846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PW9bfNWOKstyJ22vJWHCx6WLwFm7f6KVYQUcYSlc/BU=; b=ZyL85tTM/EfkxCFdD94/Un/Gv/DJe3GTsPl6NfHW7GqIwDC1vbFkP215E2BQs73IO+b4qb nIkEWSrk1G+pTsMFrQ7h99NPlQAd3OKzQPdQaY78tbqKCE0xgNv9071YHIMpA8GKz8jasT PsEkNhSHwYSJL5SkrJatF9hVvdBFQiZpT6jJdy57MLb2NleTnCHu/DLX28c3GW5FNAy5NP 8q2urL1dGxWQrX/kFQBg7dFma2+QyEVIituxH6zGQui0TQHEX0+1d+w6D9f1LAEBwofMrx gzch77GOaXIwQvLqLAwge0QHSoT2qOoHZwP0SNYptvAE7Qqq/KU1ptZAcyOx1Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714460846; a=rsa-sha256; cv=none; b=WjjMUDwaJfxdiq6DYfzBhKg+1eHkhoo8A2TPE++BPJ+8FHyRoiGCnYx1hJyu/cudm0t4Lv zKORB9t2N1ptABI8wrpg/PBlcmtoHwC2KRciSgG2qrkZ/PprFMt4RApc9oV61kHX2H1/1e 0U09b7Do53ImTQWDVPlYCd1qd6QSSUDUXyrDNg7m3bF3KStXDM7jlxO1teiTJDdlzY/YvJ wmJciBXNZ2z/qtM68lwnAMU9BCc+Ipw1sJxuqciq7DbbcsK0yMKBO+ElWbMugeEit7an96 tko7hJ+kLYvnivLvdIEeY9kUacVxFq0RhhqYiW9C44i6Kaez7jnGiu6QdzNegA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714460846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=PW9bfNWOKstyJ22vJWHCx6WLwFm7f6KVYQUcYSlc/BU=; b=Kodkw5u1YMUF2kZ+t829uMa/S130Gmlv73aKiWKE7yGGXzX/MFodQDO9I3ZadIqg3ZY6/Z hQ35IuZTXlzi/oWuzIXzilqC7oySHqEOA8OnSA2mIsLiK9Q2OMNBea8QsS6ZW3gtntZF8u Qb5gMSlSgYIODpnyes0ksEEsv7BubgxkCRZvZu5P2PHb4oTRpV3lZTrTwx83LEHNDEoAYP In4LadJwlp9VnzgtO63LX4v4qfZjXBhNXOvQsy8IYlyMYfhTdNsjxYyagFkOo9c8jZO7as k/qnv5Dsnyuk87leNk7e59UXLxJ7FF5P/9yQm18nqKGiCibReme99qUj1HKgLQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VTB8t01MPzQR3; Tue, 30 Apr 2024 07:07:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43U77PR8058323; Tue, 30 Apr 2024 07:07:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43U77Pnx058320; Tue, 30 Apr 2024 07:07:25 GMT (envelope-from git) Date: Tue, 30 Apr 2024 07:07:25 GMT Message-Id: <202404300707.43U77Pnx058320@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 5b3e5c6ce3e5 - main - kcmp_pget(): do not accept TIDs List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5b3e5c6ce3e552dae3e84d6bc781bc9f53c22d71 Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=5b3e5c6ce3e552dae3e84d6bc781bc9f53c22d71 commit 5b3e5c6ce3e552dae3e84d6bc781bc9f53c22d71 Author: Konstantin Belousov AuthorDate: 2024-04-29 21:04:25 +0000 Commit: Konstantin Belousov CommitDate: 2024-04-30 07:07:03 +0000 kcmp_pget(): do not accept TIDs Otherwise pget() might still look up and hold the current process. Reported and tested by: pho Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/kern/sys_generic.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/kern/sys_generic.c b/sys/kern/sys_generic.c index cc1126ac4dc4..99b018dee26c 100644 --- a/sys/kern/sys_generic.c +++ b/sys/kern/sys_generic.c @@ -2098,7 +2098,8 @@ kcmp_pget(struct thread *td, pid_t pid, struct proc **pp) *pp = td->td_proc; return (0); } - error = pget(pid, PGET_CANDEBUG | PGET_NOTWEXIT | PGET_HOLD, pp); + error = pget(pid, PGET_NOTID | PGET_CANDEBUG | PGET_NOTWEXIT | + PGET_HOLD, pp); MPASS(*pp != td->td_proc); return (error); }