From owner-freebsd-hackers  Sun Dec 17 13:15:13 2000
From owner-freebsd-hackers@FreeBSD.ORG  Sun Dec 17 13:15:11 2000
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from gw.nectar.com (gw.nectar.com [208.42.49.153])
	by hub.freebsd.org (Postfix) with ESMTP id ED88F37B400
	for <hackers@freebsd.org>; Sun, 17 Dec 2000 13:15:10 -0800 (PST)
Received: from hamlet.nectar.com (hamlet.nectar.com [10.0.1.102])
	by gw.nectar.com (Postfix) with ESMTP id D7BAD193E1
	for <hackers@freebsd.org>; Sun, 17 Dec 2000 15:15:09 -0600 (CST)
Received: (from nectar@localhost)
	by hamlet.nectar.com (8.11.1/8.9.3) id eBHLF9F63063
	for hackers@freebsd.org; Sun, 17 Dec 2000 15:15:09 -0600 (CST)
	(envelope-from nectar@spawn.nectar.com)
Date: Sun, 17 Dec 2000 15:15:09 -0600
From: "Jacques A. Vidrine" <n@nectar.com>
To: hackers@freebsd.org
Subject: Why not another style thread? (was Re: cvs commit: src/lib/libc/gen getgrent.c)
Message-ID: <20001217151509.A63051@hamlet.nectar.com>
References: <200012172110.eBHLAfU46563@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <200012172110.eBHLAfU46563@freefall.freebsd.org>; from nectar@FreeBSD.org on Sun, Dec 17, 2000 at 01:10:41PM -0800
X-Url: http://www.nectar.com/
Sender: nectar@nectar.com
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

[This typo came from NetBSD, so in this particular source I have no
 intention of changing the style.]
 
What do folks think about

  1)    if (data)
                free(data);

versus

  2)    free(data);

versus

  3)    #define xfree(x) if ((x) != NULL) free(x);
        xfree(data);
-- 
Jacques Vidrine / n@nectar.com / jvidrine@verio.net / nectar@FreeBSD.org

On Sun, Dec 17, 2000 at 01:10:41PM -0800, Jacques Vidrine wrote:
> nectar      2000/12/17 13:10:41 PST
> 
>   Modified files:
>     lib/libc/gen         getgrent.c 
>   Log:
>   Fix mostly harmless typo:
>   
>       if (data);
>               free(data);
>   
>   Discovered by:	emacs cc-mode
>   
>   Revision  Changes    Path
>   1.19      +2 -2      src/lib/libc/gen/getgrent.c
> 
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message