From owner-freebsd-stable@freebsd.org Fri Apr 2 22:16:03 2021 Return-Path: Delivered-To: freebsd-stable@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 126D15B4B2F for ; Fri, 2 Apr 2021 22:16:03 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670041.outbound.protection.outlook.com [40.107.67.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "DigiCert Cloud Services CA-1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FBvX15CgCz4V81; Fri, 2 Apr 2021 22:16:01 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mIcX8i5Zxim00vz0qN1d5/kToNCEI7ZEmyra7sFsx1fRjv6KrRjmuIcW8bBQ/k3ttWPbAgzYKug7cOefeRzv4AkYjZrKZGqcxKjC9CLV2Xgq6qa6YZ52JNHkytF/KX0OuybmGoKBH/k5rD3qKOB/otoqJMaFGhsHgHRcKsaXCQNjpKnjAKP5Y63geOExPnex87kTy/mBdkOUWcianaud2bfvGj8KDVXdZE+k3kr4smXSfQLuzca/KffA00vtmlcWDlZ3GYfgSgAyMTe8lWY7HhzMiOp9xhz/AJI2eWu6s1bJUreqMS0dhA3WaOmbSDGMIXOA0vD8nEICpSPA7Xh+ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H9D3MEIngGm26nBDh332Kmv9BhzyswquGeIzmF5OBCA=; b=D1sKhWCRiqsDc98u7CEMjhgaFOWJNKZMIjvkzrXywztNbk7Hf1AncyMfdQ2IBsIGsOb6bTY645PQqxcFnbgDRVvsHscjUkePqqaBqR7EkpdxVVTP0rLAGcTOXejTESIz1+WjKoLcbAHlhM8lOsPwunukm5KtDI/BKk3FzL46K+ozUG4nGRl41RbAxPXr7gE7EivmIOCUCvR3cBpxuxwUSNaVVaYiZQpnK2rk57sMVzRlT0wij4OAFjwnf14GZW1kM4+EdCZaLNCt400apFBqA2nLPUTiSR0+WdHhO0lClAKfHeo0YHsvnRThQnxKZsKHb6Jyc4RwaqsyD70hsaEvSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=uoguelph.ca; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H9D3MEIngGm26nBDh332Kmv9BhzyswquGeIzmF5OBCA=; b=vCFFhfelFgBHYa/EwZIqWGWrEjOdS42ko8or/swSxvjVAqV35/U+Bld3LbfQhfuNMUKCmew+KSEOxH2Mu+fAqdqduZhi/1L7Fpi5VSqm+NJdIcKMIiAABNcu9NBKFO9Iw6pwfS0q956JXHxyRPUqWsuNi5jtaUkt12WPDD/X+T+XmARE0uUGY5vfp6WAulP5aE9h2wovlYqcTfHZJBsTBT5linntKh2Sxyqbx88MC6XSMt9K+Ay6zhJOGu4sW4Dn1Q9pc9jVWKc4wc3b4DxFCS9u4kUuvIbD3evbq1LUvb7GHZQUKgONMYBTRRyZMvCP8ndTY0wtCnADTAdGVVWtmw== Received: from YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:19::29) by YQXPR01MB3910.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c00:50::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3977.33; Fri, 2 Apr 2021 22:15:59 +0000 Received: from YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM ([fe80::1c05:585a:132a:f08e]) by YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM ([fe80::1c05:585a:132a:f08e%4]) with mapi id 15.20.3977.037; Fri, 2 Apr 2021 22:15:59 +0000 From: Rick Macklem To: Alan Somers CC: freebsd-stable Subject: Re: FreeBSD NFSv4.1/4.2 server is broken when Linux mounts use "nconnects" Thread-Topic: FreeBSD NFSv4.1/4.2 server is broken when Linux mounts use "nconnects" Thread-Index: AQHXJOSNRrD5HzlJfk2Se+qkw1812KqhzTeAgAABZWg= Date: Fri, 2 Apr 2021 22:15:59 +0000 Message-ID: References: , In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c76fb604-7a7a-4bb8-932c-08d8f624e53e x-ms-traffictypediagnostic: YQXPR01MB3910: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 4Orrx9hyYYmE8ERcrFAH6rDMIc4kSDYiT27xOXuiyaA+q9aGIEZ4SuShJLSrMJmPg4F1LT4ztnLSiCZiEFMozFOVXyAhU0zfhThmKhYZe6KGpBM325MhpVZUJenOXw75g3WP+V5uzos/QZ4do6guLkeCpmO//pLsMnHRoJMtabd1eRzglm3Okr/8BWPmxB+XteFgYUCdIhQ47hk8Mm0hKpWSAPexIIVXUKXYElJxeZ3Zdq7m38fABQkhNvapUzJVPTTskB5+GPs15cGf9kLdR7oF6d2aXSStHc5I13iwKWr0fy8p5wkZ2s6bhKGTWizuNu+LbtZSBvidahRS3pkyErPenF03bMrFrQjLflF0ZyphCcpDwY9EMsQNT+fpGzGO0nry59dZOmGgu2q7y4+ICH8BmFqjtqv0xIdP6yFo8gq+YLTIpEVNPBc+cobYmAj7Xn89xz4ksaaOlGgn03LKXBOAdqtQj69QFDNwKKoCvd2e5yhhVGN7uUoKBAYtcVl9a7fHTNgAFdfNvfLnrzAOvWF/USk6zdXjYOzeFX9uqrFBq1hoKCl8z19yrRMTjDkl8N0Ul9xUAd4q1SRMYXJaJ55BI0YvoQ/2HjoPU5k5BTotoUnHM2LkT0O/3IBJsDGwJNCnND1blETJeOrmAbjBIVPx33GMlUo3U8iwgGHjupo= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(39850400004)(366004)(136003)(346002)(376002)(396003)(71200400001)(64756008)(66556008)(66446008)(91956017)(66946007)(6506007)(38100700001)(786003)(478600001)(316002)(7696005)(76116006)(33656002)(4326008)(2906002)(66476007)(5660300002)(9686003)(86362001)(8676002)(450100002)(55016002)(8936002)(52536014)(83380400001)(186003)(6916009); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?iso-8859-1?Q?OnFe0ukQ1Tv1GlWxKP1yZ8XV9cYfp9PfFGGyNqxJVYSZEde0ojE8lUpdG2?= =?iso-8859-1?Q?rz/s9PmOaWR5cfGnIZMYnW8I+wSz1OSGF4d7gAwWeBg5+rYZrGcubwxxvK?= =?iso-8859-1?Q?90Xz4MtRuXU7zYJ9Vqz/PRp54Pe6T9/oO68AS8ojt72NfdiDjilHZmf1FW?= =?iso-8859-1?Q?Fw0/S3XrNgiPbq5BtIuK+m05rCjOb8dNV0ho9tgA+3CE1hBnS/KXBKK4Mx?= =?iso-8859-1?Q?ZcTTP9iSz/ouu04BpNtNzpxV00Pnl6B7NOmmReK/EG6GRb+UU61vUFwT4W?= =?iso-8859-1?Q?tN9Ot6Lx7wCBe8z8yYZMxK3pyikdCUPg1ltK14wBO7jKroFU4p5W6Y4Sex?= =?iso-8859-1?Q?128AaTLUt79isA7uC0w0uo5Vv+n2qFjjJ/0z3GPou4kHB+zWBeVt+o/j3Z?= =?iso-8859-1?Q?LeGGiL5RBxdX/6VCCgZGloij47udCUMwo1PFjHSK213wfVsdtCt7QqXfvZ?= =?iso-8859-1?Q?YAHcn6/zGQEL+nP2PR8foCcaOpJqMW5xSIvxgJCxxSqHDrRsgDHy6Hoqkl?= =?iso-8859-1?Q?0oHVCTHTbMqDbLB9QrY2dRTjYXzr41c9xJx2JX5Yw3frzyH4XNcD2piGm6?= =?iso-8859-1?Q?3dw4irFr46QkQhV35JqxGbDp0JIuxZlo4A0WxXPZV/ge3beYFYawivlM8K?= =?iso-8859-1?Q?vHbzCXkCbLOZunbQp36rKHhUkP5aO97muT3Ltxl+d6/yP+O2ywrK0BGTwS?= =?iso-8859-1?Q?S21k7DWCwg7maBy2YsfTeOrdDWFyMIFRrHwBeeT0bNgWjKG7cajHcNJq5b?= =?iso-8859-1?Q?9/nigxfKKoxkihrUsgnmws3Uo9e0uMKvjs+c0EbwVvKOepONXGHdgmaKIX?= =?iso-8859-1?Q?NugLfswHwl+k1P9U50z6yWsnRoYD80RxsYBFT3VWTp06uXNq8liBHB29EO?= =?iso-8859-1?Q?wmaX8XodIHxRjwrV6T4/St+j0o5oSzPftKjJnUfe79wQCz0LJ8VZ2a6GLj?= =?iso-8859-1?Q?ptUPO/YYp0dCY05hFGuNXLnQxV/i1ju3V+4OSUcHJjW/WxWqVjLvAAqVgb?= =?iso-8859-1?Q?NuVgJYMXKKO35uqcdg64Ru4i7dGt8AlxMq+PJCNsCxVn14yXpAgWSwLY+W?= =?iso-8859-1?Q?wl8oHYnznMw/BisnoF7GZu8M7jE6az16nUW6+AZ/R6D/DUqqQyKhNUjZz7?= =?iso-8859-1?Q?2QdoDMCXTeWdWNe+FfKF0J3pCsuYzZrojKthz2W9Nb/r6zUxOdJngdmmx4?= =?iso-8859-1?Q?zsU4p80zEgGM77mTH4Pj1728SZksJ+Hq5fFmcJjFoXtn9Bg6WqACEATgGn?= =?iso-8859-1?Q?HQ10DM+NeWmijCObUYqUeEK4sza1iIZ/qJnG/5p6hbcCMec9MhShUpLisE?= =?iso-8859-1?Q?Z3J34A02z8p2R9+lW6SfyX3GUO+9iMdIgcmBrAf2kjcWT07jQlRuQsXlSS?= =?iso-8859-1?Q?3B0Ffk1of/xqVc8kTpEDQiF2/p7gshfmhY1J9tlyPILQe9qUBALsM=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: YQXPR0101MB0968.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: c76fb604-7a7a-4bb8-932c-08d8f624e53e X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Apr 2021 22:15:59.7574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6KbTUoDOTEsIJrQpreEYC7uhT7LxFyIc8m1dFQSwnPe8iPanSAqiAOqHGVAKU/pS4eUQ6L1TAOduVch2xSY2pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB3910 X-Rspamd-Queue-Id: 4FBvX15CgCz4V81 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=uoguelph.ca header.s=selector1 header.b=vCFFhfel; arc=pass (microsoft.com:s=arcselector9901:i=1); dmarc=pass (policy=none) header.from=uoguelph.ca; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.41 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; RBL_DBL_DONT_QUERY_IPS(0.00)[40.107.67.41:from]; R_DKIM_ALLOW(-0.20)[uoguelph.ca:s=selector1]; FREEFALL_USER(0.00)[rmacklem]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_SHORT(1.00)[1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; DWL_DNSWL_LOW(-1.00)[uoguelph.ca:dkim]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[uoguelph.ca:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[40.107.67.41:from]; DMARC_POLICY_ALLOW(-0.50)[uoguelph.ca,none]; SPAMHAUS_ZRD(0.00)[40.107.67.41:from:127.0.2.255]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:8075, ipnet:40.104.0.0/14, country:US]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; MAILMAN_DEST(0.00)[freebsd-stable]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.107.67.41:from] X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Apr 2021 22:16:03 -0000 Alan Somers wrote:=0A= >On Mon, Mar 29, 2021 at 3:52 PM Rick Macklem > wrote:=0A= >>Hi,=0A= >>=0A= >>The FreeBSD NFS server is broken when handling multiple=0A= >>connections for NFSv4.1/4.2.=0A= >>It incorrectly binds the back channel to a new connection=0A= >>when is sees an RPC with Sequence in it (almost all RPCs)=0A= >>and might send a callback on the wrong connection.=0A= >>=0A= >>I have a fix, but it won't be in a release until 12.3/13.1.=0A= >>It can be found in Bugzilla PR#254560.=0A= >>=0A= >>In the meantime, avoid using the "nconnects" option=0A= >>on Linux client mounts.=0A= >>=0A= >>Thanks go to Ben Coddington @redhat for diagnosing=0A= >>this and testing the patch.=0A= >>=0A= >>Sorry about the breakage, rick=0A= >>ps: It was done intentionally long ago, when clients=0A= >> did not do BindConnectionToSession and then slipped=0A= >> through the cracks.=0A= >=0A= >I've tested the patch and it works. Specifically:=0A= >=0A= >* Without the patch and without nconnect, everything works on both 12.2 an= d 13.0.=0A= >* Without the patch, with nconnect, and without delegations, everything wo= rks on 12.2, but on 13.0 clients lock up >when they try file I/O.=0A= Hmm. The 12.2 and 13.0 code is the same w.r.t. The only difference I can th= ink of=0A= is that 13.0 has 4.2 in it and Linux tends to use the newest version suppor= ted by the server.=0A= =0A= >* Without the patch, with nconnect, and with delegations, clients lock up = on both 12.2 and 13.0.=0A= >* With the patch on 13.0, everything works even with nconnect and delegati= ons.=0A= thanks for doing the testing, although it would have been more fun to crash= the Linux systems.;-)=0A= =0A= >I haven't tried backporting the patch to 12.2 yet.=0A= The code hasn't changed in a long time, so it should drop in without diffic= ulty, but it also=0A= probably doesn't need testing.=0A= =0A= rick=0A= ps: I've already committed it to current/main.=0A= =0A= -Alan=0A=