From owner-freebsd-stable@FreeBSD.ORG Sat Sep 22 03:17:29 2012 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6AACD106564A; Sat, 22 Sep 2012 03:17:29 +0000 (UTC) (envelope-from jim.harris@gmail.com) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 08C118FC08; Sat, 22 Sep 2012 03:17:28 +0000 (UTC) Received: by vcbfw7 with SMTP id fw7so5975746vcb.13 for ; Fri, 21 Sep 2012 20:17:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=Gih5T1FqYB4Gm2P8g/ju0fYxys9AmSf59WVRlSZ+Iwo=; b=s6EFLFUB1eCjMTGQCrCDi4wgqcYLo5jMkIJL9VCh3uMi4kyko5H7Ov1PZP8GVTHhEv f1R8ROoTJFJ8Bdy0SY8aRUSgzJb5m2cmbMhXqM/qm0psGwndmJvcwHbXiFmFfuGY4cNz 7iqCbLHcdya+ZOq1ncUDqo+fBiEumdV7dKvRpcB09PldGLWtnUgUHuTwKfwFui1d34FH 2NmhvU29JToynkow1G/cfPI7lyJ9ApWr5Ks1hYVveq861DZUvd0gfRCZA6To9fRkOl5a AVzcrTwBF9oU/znldg7V2K034xEUBxd+LV3Bzmk72zDgK4psOfUWy/pK144j8fZg714X gB5g== MIME-Version: 1.0 Received: by 10.58.116.175 with SMTP id jx15mr4189991veb.6.1348283848385; Fri, 21 Sep 2012 20:17:28 -0700 (PDT) Sender: jim.harris@gmail.com Received: by 10.58.249.135 with HTTP; Fri, 21 Sep 2012 20:17:28 -0700 (PDT) In-Reply-To: <505D0846.8050108@sentex.net> References: <505CC8EC.4030608@sentex.net> <505CE601.4070106@sentex.net> <505D0846.8050108@sentex.net> Date: Fri, 21 Sep 2012 20:17:28 -0700 X-Google-Sender-Auth: VwDUVDIP60Y6hc9gjTYuchHPeis Message-ID: From: Jim Harris To: Mike Tancsa Content-Type: text/plain; charset=ISO-8859-1 Cc: FreeBSD-STABLE Mailing List , delphij@freebsd.org Subject: Re: tws bug ? (LSI SAS 9750) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Sep 2012 03:17:29 -0000 On Fri, Sep 21, 2012 at 5:37 PM, Mike Tancsa wrote: > On 9/21/2012 8:03 PM, Jim Harris wrote: >>> . >>> then a lot of >>> . >>> (probe65:tws0:0:65:0): INQUIRY. CDB: 12 0 0 0 24 0 >>> (probe65:tws0:0:65:0): CAM status: Invalid Target ID >>> (probe65:tws0:0:65:0): Error 22, Unretryable error >>> (probe1:tws0:0:1:0): INQUIRY. CDB: 12 0 0 0 24 0 >>> (probe1:tws0:0:1:0): CAM status: Invalid Target ID >>> (probe1:tws0:0:1:0): Error 22, Unretryable error >>> (probe2:tws0:0:2:0): INQUIRY. CDB: 12 0 0 0 24 0 >>> (probe2:tws0:0:2:0): CAM status: Invalid Target ID >>> . >>> . >>> . >>> (probe63:tws0:0:63:0): INQUIRY. CDB: 12 0 0 0 24 0 >>> (probe63:tws0:0:63:0): CAM status: Invalid Target ID >>> (probe63:tws0:0:63:0): Error 22, Unretryable error >>> (probe64:tws0:0:64:0): INQUIRY. CDB: 12 0 0 0 24 0 >>> (probe64:tws0:0:64:0): CAM status: Invalid Target ID >>> (probe64:tws0:0:64:0): Error 22, Unretryable error >> >> These can be ignored. CAM is just telling you that there are no >> devices attached at these target IDs. > > What about a change similar to what Alexander Motin did in > > http://lists.freebsd.org/pipermail/svn-src-head/2012-June/038196.html Ah, yes. I was thinking you had CAM_DEBUG enabled which is why you were seeing this spew - but that's not the case. This indeed should be fixed and not just ignored. Seeing the attributions on Alexander's commit, you certainly seem to have a monopoly on controllers that exhibit this problem on FreeBSD. :) I believe the CAM_LUN_INVALID here should be fixed as well, similar to the twa commit. If you send me a revised patch I will commit it. Thanks, -Jim > > 0(ich10)# diff -u tws_cam.c.orig tws_cam.c > --- tws_cam.c.orig 2012-09-21 20:10:43.000000000 -0400 > +++ tws_cam.c 2012-09-21 20:11:11.000000000 -0400 > @@ -532,7 +532,7 @@ > ccb->ccb_h.status |= CAM_LUN_INVALID; > } else { > TWS_TRACE_DEBUG(sc, "invalid target error",0,0); > - ccb->ccb_h.status |= CAM_TID_INVALID; > + ccb->ccb_h.status |= CAM_SEL_TIMEOUT; > } > > } else { > 1(ich10)# > > ---Mike > > > -- > ------------------- > Mike Tancsa, tel +1 519 651 3400 > Sentex Communications, mike@sentex.net > Providing Internet services since 1994 www.sentex.net > Cambridge, Ontario Canada http://www.tancsa.com/