From owner-cvs-src@FreeBSD.ORG  Wed Oct 26 17:08:11 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 755B616A41F;
	Wed, 26 Oct 2005 17:08:11 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DA66743D45;
	Wed, 26 Oct 2005 17:08:06 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id j9QH84rK032338;
	Wed, 26 Oct 2005 11:08:05 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <435FB7F4.6020700@samsco.org>
Date: Wed, 26 Oct 2005 11:08:04 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.7) Gecko/20050416
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Maksim Yevmenkin <maksim.yevmenkin@gmail.com>
References: <200510260617.j9Q6HRqh082376@repoman.freebsd.org>	
	<200510261100.55974.jhb@freebsd.org>
	<bb4a86c70510260933h421557eeicfc63569da70bcd0@mail.gmail.com>
In-Reply-To: <bb4a86c70510260933h421557eeicfc63569da70bcd0@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.0
X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on pooker.samsco.org
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Ruslan Ermilov <ru@FreeBSD.org>, cvs-all@FreeBSD.org,
	John Baldwin <jhb@FreeBSD.org>
Subject: Re: cvs commit: src/sys/netgraph/bluetooth/drivers/bt3c
	ng_bt3c_pccard.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Oct 2005 17:08:11 -0000

Maksim Yevmenkin wrote:

> John,
> 
> [...]
> 
> 
>>Sorry about that, will be fixing it more cleanly.  BTW, does anyone know why
>>this driver allocates its softc manualn in its attach routine?
> 
> 
> ng_bt3c(4) is a netgraph device driver. there could be failures in
> both device part (i/o port, interrupts etc.) as well as in netgraph
> part (could not create node). so decided to do it this way. right now
> i can not recall any other reason :)
> 
> thanks,
> max

If the driver is attaching via normal newbus methods, and the bluetooth
stack hasn't done something strange to override this, then there is no
need to not trust the softc that is automatically provided.

Scott