From owner-freebsd-stable@FreeBSD.ORG  Sun Apr  3 23:52:13 2011
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id BA639106564A;
	Sun,  3 Apr 2011 23:52:13 +0000 (UTC)
	(envelope-from victor@bsdes.net)
Received: from equilibrium.bsdes.net
	(244.Red-217-126-240.staticIP.rima-tde.net [217.126.240.244])
	by mx1.freebsd.org (Postfix) with ESMTP id 65C938FC13;
	Sun,  3 Apr 2011 23:52:12 +0000 (UTC)
Received: by equilibrium.bsdes.net (Postfix, from userid 1001)
	id 6BD4539845; Mon,  4 Apr 2011 01:51:24 +0200 (CEST)
Date: Mon, 4 Apr 2011 01:51:24 +0200
From: Victor Balada Diaz <victor@bsdes.net>
To: Mikolaj Golub <trociny@freebsd.org>
Message-ID: <20110403235124.GF1289@equilibrium.bsdes.net>
References: <20110326003348.GQ36706@equilibrium.bsdes.net>
	<20110401174354.GE1289@equilibrium.bsdes.net>
	<86pqp53cqe.fsf@kopusha.home.net>
	<20110402101750.GD1849@garage.freebsd.pl>
	<86zko7nsby.fsf@kopusha.home.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <86zko7nsby.fsf@kopusha.home.net>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: Kostik Belousov <kib@FreeBSD.org>, stable@freebsd.org,
	Pawel Jakub Dawidek <pjd@FreeBSD.org>
Subject: Re: geli(4) memory leak
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 03 Apr 2011 23:52:13 -0000

On Sun, Apr 03, 2011 at 08:43:45PM +0300, Mikolaj Golub wrote:
> 
> On Sat, 2 Apr 2011 12:17:50 +0200 Pawel Jakub Dawidek wrote:
> 
>  PJD> On Sat, Apr 02, 2011 at 12:04:09AM +0300, Mikolaj Golub wrote:
>  >> For me your patch look correct. But the same issue is for read :-). Also, to
>  >> avoid the leak I think we can just do g_destroy_bio() before "all sectors"
>  >> check. See the attached patch (had some testing).
> 
>  PJD> The patch looks good. Please commit.
> 
> Commited, thanks.

I've been out all the weekend, so i've been unable to answer before. I'm glad
it got commited and it's great you discovered and fixed the same problem on the
read path.

Are there any plans to MFC this?

Thanks a lot.
Regards.

-- 
La prueba más fehaciente de que existe vida inteligente en otros
planetas, es que no han intentado contactar con nosotros.