From owner-dev-commits-ports-main@freebsd.org Sun Jul 25 06:11:48 2021 Return-Path: Delivered-To: dev-commits-ports-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E3CA9653397; Sun, 25 Jul 2021 06:11:48 +0000 (UTC) (envelope-from mfechner@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4GXXkr60vSz4rln; Sun, 25 Jul 2021 06:11:48 +0000 (UTC) (envelope-from mfechner@FreeBSD.org) Received: from [IPv6:2a02:6d40:36e5:201:5d69:dc90:1472:c24c] (unknown [IPv6:2a02:6d40:36e5:201:5d69:dc90:1472:c24c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: mfechner) by smtp.freebsd.org (Postfix) with ESMTPSA id 26BC12BEFE; Sun, 25 Jul 2021 06:11:48 +0000 (UTC) (envelope-from mfechner@FreeBSD.org) Subject: Re: git: e497a16a2869 - main - ports-mgmt/pkg*: Release 1.17.0 To: Bryan Drewery , Baptiste Daroussin , ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org References: <202107220806.16M862GC052436@gitrepo.freebsd.org> From: Matthias Fechner Message-ID: <6572a5ce-42c4-39e1-17dd-7df413de17b9@FreeBSD.org> Date: Sun, 25 Jul 2021 08:11:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dev-commits-ports-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the main branch of the FreeBSD ports repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Jul 2021 06:11:49 -0000 Am 24.07.2021 um 22:35 schrieb Bryan Drewery: > I love the idea here but can this be reverted for now please? Poudriere > is not prepared for a default PKG_EXT change. > > 1. Now that it finds a new PKG_EXT of .pkg, it cannot find the existing > bootstrap pkg.txz because it looks for Latest/pkg.pkg -> > ../All/pkg-*.pkg even though the *existing* one is .txz. I'm not sure > how this symlink is added before pkg is even built but it's not done in > a compatible way. > > 2. The new PKG_EXT makes Poudriere now find no existing packages so > everything is rebuilt. Not a deal breaker in itself but a problem for > future builds... > > 3. The rebuild won't remove all the .txz files. I assume once `pkg repo` > runs it will find both .txz and .pkg files and cause duplicate version > problems in `pkg repo` > > I see something creates a .txz -> .pkg symlink. What deles that symlink > if Poudriere only deletes/rebuilds the .pkg? > > *** > "all those .txz entries are actually _duplicates_ in packagesite.yaml" > seen on IRC just now by someone. > I can confirm that looking in a packagesite.yaml I just generated. Both > the older .txz version of a port and a new revision-bumped one appear in > the yaml. > *** > > 4. I've seen reports of packagesite.pkg which is concerning because > Poudriere manages packagesite.txz with its own symlinks for > hardlink-copied repositories. It does not use PKG_EXT there as they > weren't packages, but I suspect we need special handling even with > PKG_EXT added there. > I do not have a fancy setup. I rolled yesterday updates to all FreeBSD servers I maintain and saw no problem. Poudriere was rebuilding all packages, I use on my build server: cd /usr/local/etc/poudriere.d/ && poudriere bulk -t -j 130amd64 -f pkglist cd /usr/local/etc/poudriere.d/ && poudriere pkgclean -y -j 130amd64 -f pkglist While upgrading the servers itself, I upgraded first pkg and then all other packages as usual. All updates were nicely installed. So I do not really understand what you are complaining here for pkg 1.17.0 upgrade. Gruß Matthias -- "Programming today is a race between software engineers striving to build bigger and better idiot-proof programs, and the universe trying to produce bigger and better idiots. So far, the universe is winning." -- Rich Cook