From owner-freebsd-audit Fri Mar 15 17: 4:41 2002 Delivered-To: freebsd-audit@freebsd.org Received: from mail.rpi.edu (mail.rpi.edu [128.113.22.40]) by hub.freebsd.org (Postfix) with ESMTP id 5E58F37B404; Fri, 15 Mar 2002 17:04:32 -0800 (PST) Received: from [128.113.24.47] (gilead.acs.rpi.edu [128.113.24.47]) by mail.rpi.edu (8.12.1/8.12.1) with ESMTP id g2G14U4B117358; Fri, 15 Mar 2002 20:04:30 -0500 Mime-Version: 1.0 X-Sender: drosih@mail.rpi.edu Message-Id: In-Reply-To: <20020315231100.A20942@FreeBSD.ORG> References: <20020315231100.A20942@FreeBSD.ORG> Date: Fri, 15 Mar 2002 20:04:29 -0500 To: "J. Mallett" , freebsd-audit@FreeBSD.ORG From: Garance A Drosihn Subject: Re: patch for review: xargs standards compliance Cc: "J. Mallett" Content-Type: text/plain; charset="us-ascii" ; format="flowed" X-Scanned-By: MIMEDefang 2.3 (www dot roaringpenguin dot com slash mimedefang) Sender: owner-freebsd-audit@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG At 11:11 PM +0000 3/15/02, J. Mallett wrote: >The patch is available here: > http://people.freebsd.org/~jmallett/xargs.patch > >Relative to -rHEAD right now. > >In detail, it adds: -E, -I, -L, -t; As far as flags go. I like the idea, I particularly like the idea when someone else writes all the code... :-) I don't see why you added: +# $xMach: Makefile,v 1.1.1.2 2002/02/22 19:31:35 jmallett Exp $ to the makefile. But it probably will need a $FreeBSD$ in there somewhere, or you'll have trouble when you go to check it in. For the new routine strnsubst.c, I believe the current practice for including $FreeBSD$ in a '.c' file is not to add it to a comment, but to add: #include __FBSDID("$FreeBSD$"); after that first comment block. (I believe there's supposed to be a blank line between the closing '*/' and the include for sys/cdefs.h, and no blank line between that and the __FBSDID line) The actual update looks OK, but I've only skimmed through it and I haven't tried to apply it and put it through any torture testing. >I'm looking to commit this after the weekend, so review would >be appreciated, comments and flames welcome... Three days >sound good? It would be better to wait more than just a weekend. Despite popular folklore, many of us do sometimes go thru a whole weekend without checking the mailing lists for new code... :-) -- Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Senior Systems Programmer or gad@freebsd.org Rensselaer Polytechnic Institute or drosih@rpi.edu To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-audit" in the body of the message