From owner-svn-src-head@freebsd.org Tue May 29 14:00:42 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D5D39F7EDF4; Tue, 29 May 2018 14:00:41 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-it0-x22d.google.com (mail-it0-x22d.google.com [IPv6:2607:f8b0:4001:c0b::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C6EC6C081; Tue, 29 May 2018 14:00:41 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-it0-x22d.google.com with SMTP id q4-v6so18641622ite.3; Tue, 29 May 2018 07:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=3/KdypskOHYrwtSxA/dakIoOSSBvG5U6RQ50GMt3Yz0=; b=K6J600qZbJrz+Hb87E+r5ZdJkbZf2jOpyKT2aLEdXrDJT3LoC/FLCKNvpdUYg0iCRm ksWkt3vcd57VSOzrxY6KOVF0sDBxrZM7SEulYznj3nVvk9tYxZ0g22URkJ5NKyDRsEcX /t2UhcDkSe6JuYUYqQgIlTkJsXmavH2tzPHblvQoh3FjSIfkIuYXokVG+bjE2sFpfp+s YHlP2ZpejbxyEans2d7RtYBELmQgCTag/FPjCDPwYf3ZRZmmtLeEZEhnDthwMWwXdfCo ZWToht47/3V5fkEpIypOLlO1yBLRSBAy1kH5d9fr22UILtZHXMvtBEuvjiIOVhdzdTHn IcFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=3/KdypskOHYrwtSxA/dakIoOSSBvG5U6RQ50GMt3Yz0=; b=gp27WEd6YaV3Pi9mC3tRNCqkOMSBZPobFeQX3pBEQOGAkt4RLqjiPGbPScqielM1ea 1s1n79hWOmQU62Mptl2FMwxeFouGzMd6PbEztKtNTT/Oxl6waAOauVslgD5Sp+yfljRv VxCSMJyNCqZJRlIMH1aWvnQa75INB0pNU/BEyTmB+AkHkXFHLfclXMQ6atXdV4atbiEp xN38WtoLeZAHHq5TCBCG9B03bQ4KrwwlQvHEhQz6IVLCUzKljKoyHzH59XxIs/h7zY0r +KPfPDjGXzpc0yiwK8F3cL8qoeOkIfT4JWJBthTX41Lj+lM1tPA70xhJVGJKz0VgeJIo LyTw== X-Gm-Message-State: ALKqPwdEOZ1PouNhD44sbAYGSU0wps43gmQw277FnUC3aJ7GgafXTVRl FWhyq3+ssC5oQOYcI/qVw8sVApzs/JMIRsblv+Z0Eg== X-Google-Smtp-Source: ADUXVKIzljzyWeUMy+LWVVC+98rclGRdAetGSEKCPfnEW5S/dWkLhswy82yz4C58imu0l7nLXSrnfuRdRtcODedmQyg= X-Received: by 2002:a24:19c9:: with SMTP id b192-v6mr15543880itb.78.1527602440873; Tue, 29 May 2018 07:00:40 -0700 (PDT) MIME-Version: 1.0 Sender: carpeddiem@gmail.com Received: by 2002:a6b:87c4:0:0:0:0:0 with HTTP; Tue, 29 May 2018 07:00:20 -0700 (PDT) In-Reply-To: <168f4cd3-07d2-15cb-9cf4-a2d02f6dc260@selasky.org> References: <201805291302.w4TD2bR5059884@slippy.cwsent.com> <168f4cd3-07d2-15cb-9cf4-a2d02f6dc260@selasky.org> From: Ed Maste Date: Tue, 29 May 2018 10:00:20 -0400 X-Google-Sender-Auth: QSXSY__FW0t4lHFmTvaoZgRIrOM Message-ID: Subject: Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include To: Hans Petter Selasky Cc: Cy Schubert , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 14:00:42 -0000 On 29 May 2018 at 09:10, Hans Petter Selasky wrote: > > I only tested buildkernel i386 LINT + GENERIC with this change. I will have > a look ASAP. On IRC the suggestion was made to run buildworld for any header change, and I think this seems like a reasonable standard. Our full buildworld times are admittedly quite long, so if you have a suitably up-to-date toolchain on the build host you can skip building toolchain components with something like: make -DWITHOUT_TOOLCHAIN -DWITHOUT_CLANG_BOOTSTRAP -DWITHOUT_LLD_BOOTSTRAP buildworld That should give much of the build coverage benefit without taking so long. On my little NUC desktop (with -j8) this took about 30 minutes. In addition many folks have put a lot of effort into making non-clean builds work - both meta-mode and conventional. I've generally been building with -DNO_CLEAN for a few years now. The same build with -DNO_CLEAN added and after `touch atomic.h` (again on the NUC) took about 3 minutes.