From owner-freebsd-current@FreeBSD.ORG  Mon Oct 24 12:27:52 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D793A106566C;
	Mon, 24 Oct 2011 12:27:52 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id AD9BC8FC0A;
	Mon, 24 Oct 2011 12:27:52 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 606B846B2A;
	Mon, 24 Oct 2011 08:27:52 -0400 (EDT)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 013AC8A02F;
	Mon, 24 Oct 2011 08:27:52 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-current@freebsd.org
Date: Mon, 24 Oct 2011 07:59:54 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110617; KDE/4.5.5; amd64; ; )
References: <20111020114844.GK59810@albert.catwhisker.org>
	<alpine.BSF.2.00.1110220801140.38610@toaster.local>
	<4EA2EFDD.4020507@gmail.com>
In-Reply-To: <4EA2EFDD.4020507@gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201110240759.54727.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Mon, 24 Oct 2011 08:27:52 -0400 (EDT)
Cc: Garrett Cooper <yanegomi@gmail.com>,
	Craig Rodrigues <rodrigc@crodrigues.org>, Doug Barton <dougb@freebsd.org>,
	"Luchesar V. ILIEV" <luchesar.iliev@gmail.com>
Subject: Re: sys/conf/newvers.sh vs. subversion-1.7
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Oct 2011 12:27:52 -0000

On Saturday, October 22, 2011 12:31:25 pm Luchesar V. ILIEV wrote:
> Speaking of that, and in the context of the recursion that svnversion
> does, something else comes to my mind...
> 
> svnversion is currently executed in ${SRCDIR}/sys, so the revision
> number is relevant only to the kernel sources. But FreeBSD is not just a
> kernel, unlike Linux, so wouldn't it make more sense to actually check
> the revision directly at ${SRCDIR}, thus catching possible different
> revisions in other parts of the base system source tree?

Please no.  That makes svnversion take a _lot_ longer.  We used to do that,
but changed it.  Also, the kernel build does not use any sources outside
of sys/, so for the kernel an svnversion of sys/ is perfectly reasonable.

-- 
John Baldwin