From owner-freebsd-bugs  Fri Sep 15 23:10:03 1995
Return-Path: owner-bugs
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id XAA00199
          for bugs-outgoing; Fri, 15 Sep 1995 23:10:03 -0700
Received: (from gnats@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id XAA00193
          ; Fri, 15 Sep 1995 23:10:01 -0700
Resent-Date: Fri, 15 Sep 1995 23:10:01 -0700
Resent-Message-Id: <199509160610.XAA00193@freefall.freebsd.org>
Resent-From: gnats (GNATS Management)
Resent-To: freebsd-bugs
Resent-Reply-To: FreeBSD-gnats@freefall.FreeBSD.org, syssgm@devetir.qld.gov.au
Received: from bunyip.cc.uq.oz.au (pp@bunyip.cc.uq.oz.au [130.102.2.1])
          by freefall.freebsd.org (8.6.12/8.6.6) with SMTP id XAA29846
          for <FreeBSD-gnats-submit@freebsd.org>; Fri, 15 Sep 1995 23:00:20 -0700
Received: from cc.uq.oz.au by bunyip.cc.uq.oz.au 
          id <29558-0@bunyip.cc.uq.oz.au>; Sat, 16 Sep 1995 16:00:02 +1000
Received: from stupid.devetir.qld.gov.au 
          by pandora.devetir.qld.gov.au (8.6.10/DEVETIR-E0.3a) with ESMTP 
          id QAA19921; Sat, 16 Sep 1995 16:04:38 +1000
Received: (from syssgm@localhost) by stupid.devetir.qld.gov.au (8.6.12/8.6.9) 
          id PAA02308; Sat, 16 Sep 1995 15:42:30 +1000
Message-Id: <199509160542.PAA02308@stupid.devetir.qld.gov.au>
Date: Sat, 16 Sep 1995 15:42:30 +1000
From: Stephen McKay <syssgm@devetir.qld.gov.au>
Reply-To: syssgm@devetir.qld.gov.au
To: FreeBSD-gnats-submit@freebsd.org
Cc: syssgm@devetir.qld.gov.au
X-Send-Pr-Version: 3.2
Subject: bin/722: Off-by-one error in wbkgd() in ncurses
Sender: owner-bugs@freebsd.org
Precedence: bulk


>Number:         722
>Category:       bin
>Synopsis:       Off-by-one error in wbkgd() in ncurses
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Sep 15 23:10:01 PDT 1995
>Last-Modified:
>Originator:     Paul Koch
>Organization:
>Release:        FreeBSD 2.2-CURRENT i386
>Environment:

	FreeBSD 2.0.5 on a 16Mb 486DX50

>Description:

	[ I'm posting this for Paul Koch, who has no net connection. ]

	I found when using the ncurses library call 'wbkgd', the entire
	background was not being painted properly. eg on a 80*25 window,
	the last column and last line were being painted incorrectly.

>How-To-Repeat:

>Fix:

*** libncurses/lib_bkgd.c.old	Mon Sep  4 12:56:29 1995
--- libncurses/lib_bkgd.c	Mon Sep  4 12:57:11 1995
***************
*** 25,32 ****
  int x, y;
  
  	T(("wbkgd(%x, %x) called", win, ch));
! 	for (y = 0; y < win->_maxy; y++)
! 		for (x = 0; x < win->_maxx; x++)
  			if (win->_line[y][x]&A_CHARTEXT == ' ')
  				win->_line[y][x] |= ch;
  			else
--- 25,32 ----
  int x, y;
  
  	T(("wbkgd(%x, %x) called", win, ch));
! 	for (y = 0; y <= win->_maxy; y++)
! 		for (x = 0; x <= win->_maxx; x++)
  			if (win->_line[y][x]&A_CHARTEXT == ' ')
  				win->_line[y][x] |= ch;
  			else

EOF
>Audit-Trail:
>Unformatted: