From owner-cvs-src@FreeBSD.ORG Sun Aug 8 04:27:06 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E80016A4CF; Sun, 8 Aug 2004 04:27:06 +0000 (GMT) Received: from ylpvm15.prodigy.net (ylpvm15-ext.prodigy.net [207.115.57.46]) by mx1.FreeBSD.org (Postfix) with ESMTP id CCABF43D3F; Sun, 8 Aug 2004 04:27:05 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (adsl-67-115-74-195.dsl.lsan03.pacbell.net [67.115.74.195]) i784R6jx012748; Sun, 8 Aug 2004 00:27:07 -0400 Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 0ADED513B6; Sat, 7 Aug 2004 21:27:04 -0700 (PDT) Date: Sat, 7 Aug 2004 21:27:03 -0700 From: Kris Kennaway To: John Baldwin Message-ID: <20040808042703.GA64746@xor.obsecurity.org> References: <200408042031.i74KVKUf039025@repoman.freebsd.org> <200408041634.03998.jhb@FreeBSD.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J/dobhs11T7y2rNN" Content-Disposition: inline In-Reply-To: <200408041634.03998.jhb@FreeBSD.org> User-Agent: Mutt/1.4.2.1i cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 pmap.c src/sys/kern subr_witness.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Aug 2004 04:27:06 -0000 --J/dobhs11T7y2rNN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 04, 2004 at 04:34:03PM -0400, John Baldwin wrote: > On Wednesday 04 August 2004 04:31 pm, John Baldwin wrote: > > jhb 2004-08-04 20:31:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/i386/i386 pmap.c > > sys/kern subr_witness.c > > Log: > > Remove a potential deadlock on i386 SMP by changing the lazypmap ipi = and > > spin-wait code to use the same spin mutex (smp_tlb_mtx) as the TLB ipi > > and spin-wait code snippets so that you can't get into the situation = of > > one CPU doing a TLB shootdown to another CPU that is doing a lazy pmap > > shootdown each of which are waiting on each other. With this change, > > only one of the CPUs would do an IPI and spin-wait at a time. >=20 > Both this patch and the previous I have tested locally and also sent out = to=20 > current@ for testing. However, I received zero feedback (not even useles= s=20 > feedback), so they may theoretically be risky. Isn't this the patch I tested for you and reported that it did not fix the problem? Kris --J/dobhs11T7y2rNN Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQFBFauXWry0BWjoQKURAtsSAJwLfr/lnd0zZHfqElt5mrLNikajYQCg7Al9 IKfOqloZUDxUB7G9tvBbSnw= =g0s5 -----END PGP SIGNATURE----- --J/dobhs11T7y2rNN--