From nobody Mon Oct 27 19:11:43 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cwNR35Lr0z6FMDf; Mon, 27 Oct 2025 19:11:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cwNR34nYlz3N3C; Mon, 27 Oct 2025 19:11:43 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761592303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uCoPQCuz4YpIyWV7+Or8zPeV5YG+nY4enTyQD6xm1bg=; b=gFWB2SLT9h7Wa8YMmrIV34U4yZbJuZqJ6ZlJualnrq057cYuuT43byKh13gc6eKKBBoWSC TeXuJkxI0A26gVcW+jvsHU+peDX8h/bgljzmqRMY5BsXGilEwaaQlOZ36eoL8RMEvTITcq cpdCzFhD1pxKFJydzQYiq7fk/POEqVz6Y5svrwiaJmv/WxWMzNgMHQTZRaGZpne396NQO1 aAoGC7tQxXVqHus+mLgMaK4+AGuMXlof3HjebD7V5spscYURG9wQuBirBm4rtXs+K0NoPs Dp245SZZTOmCUZogD5bCCBz3izLVQd9M7S6NT+2D2lwO9zqeH58VbeT6V0mZ+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1761592303; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=uCoPQCuz4YpIyWV7+Or8zPeV5YG+nY4enTyQD6xm1bg=; b=mWQiGdta2hTa69/1oilOEdCo/gZhFZONkiR/GqtxziFwwDO2He1w2dy4lVldttFksQO85S do99GoryypZUAJyTH5F5qkJxTrsE8FsbWpkH5kWnI+OMEopUqs57Q1Vq4/TIrXnJ3rEwve e+d1au6LDjs3IFyPHaxs0y4h2Tw3xz7NQ+BXu5DooyXVgYJbObMm5IZlCS+7+3Dor6vRBc MX4skgIJ391KrJs49d5DaC0E7BBO+3C1ynea5WDza/MxdiRea2exRQ29CeBLQ4n1ggiQX3 c5ncwVltQD9eln17yeQxToGFwXXlBS4Sgy/UUKVbKlReuZ/jVZ2Z3l20WqH95g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1761592303; a=rsa-sha256; cv=none; b=R2cq9WiF1h3EIiWABFj9GuIYsjuHM2LXKCN+0rRS1/wROO1WPn3ISXY+WQVoedp6mZECw3 gaBor7pSOjF646u0XUi3XgFXJQfMfmgppQztXCQrd9NxAt1PQrM4fRIXc6OSeQqqFcoDfp wP9VzTRVgM8LJ+idHbW53ezMkMHfObp8gWpLWRzGXKY05gQh3kHT5MAyirAtfGNieU2TSy NE5OG84h/i7yB/vF0Itn4akeyuxm7Pcfmb1BCATK093hCPyHsuiunGRB8O73DNIQsmhCGl x2AP9GwhI45iS2hVONTfcmOVQWPmPUoeCZaHa8NdRonoSvnQxWWlVbeW0YC4UQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cwNR347Mcz1nD; Mon, 27 Oct 2025 19:11:43 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59RJBhsb017517; Mon, 27 Oct 2025 19:11:43 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59RJBhnG017514; Mon, 27 Oct 2025 19:11:43 GMT (envelope-from git) Date: Mon, 27 Oct 2025 19:11:43 GMT Message-Id: <202510271911.59RJBhnG017514@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Alan Somers Subject: git: d86025c1d49c - main - fusefs: Fix intermittency in the BadServer.ShortWrite test case List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: asomers X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d86025c1d49c84c4dc8c3635c83c078ad56e5a53 Auto-Submitted: auto-generated The branch main has been updated by asomers: URL: https://cgit.FreeBSD.org/src/commit/?id=d86025c1d49c84c4dc8c3635c83c078ad56e5a53 commit d86025c1d49c84c4dc8c3635c83c078ad56e5a53 Author: Alan Somers AuthorDate: 2025-10-25 22:38:30 +0000 Commit: Alan Somers CommitDate: 2025-10-27 19:11:19 +0000 fusefs: Fix intermittency in the BadServer.ShortWrite test case We were using the m_quit bit for two similar but distinct uses: * To instruct the server to quit * To cope with the kernel forcibly unmounting the fs Fix the intermittent test failure by adding a separate bit, m_expect_unmount, to handle cases like the latter. Reported by: Siva Mahadevan MFC after: 1 week Revied by: Siva Mahadevan Differential Revision: https://reviews.freebsd.org/D53357 --- tests/sys/fs/fusefs/bad_server.cc | 8 ++++---- tests/sys/fs/fusefs/mockfs.cc | 5 +++-- tests/sys/fs/fusefs/mockfs.hh | 3 +++ 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/tests/sys/fs/fusefs/bad_server.cc b/tests/sys/fs/fusefs/bad_server.cc index c3d195735446..825523cac2bb 100644 --- a/tests/sys/fs/fusefs/bad_server.cc +++ b/tests/sys/fs/fusefs/bad_server.cc @@ -64,12 +64,12 @@ TEST_F(BadServer, ShortWrite) out.header.error = 0; out.header.unique = 0; // Asynchronous notification out.expected_errno = EINVAL; - m_mock->write_response(out); /* - * Tell the event loop to quit. The kernel has already disconnected us + * Tell the event loop to quit. The kernel will disconnect us * because of the short write. */ - m_mock->m_quit = true; + m_mock->m_expect_unmount = true; + m_mock->write_response(out); } /* @@ -98,7 +98,7 @@ TEST_F(BadServer, ErrorWithPayload) out.push_back(std::move(out1)); // The kernel may disconnect us for bad behavior, so don't try - // to read any more. + // to read or write any more. m_mock->m_quit = true; })); diff --git a/tests/sys/fs/fusefs/mockfs.cc b/tests/sys/fs/fusefs/mockfs.cc index 55c191716629..b6a32d9b60af 100644 --- a/tests/sys/fs/fusefs/mockfs.cc +++ b/tests/sys/fs/fusefs/mockfs.cc @@ -433,7 +433,8 @@ MockFS::MockFS(int max_read, int max_readahead, bool allow_other, m_child_pid(-1), m_maxwrite(MIN(max_write, max_max_write)), m_nready(-1), - m_quit(false) + m_quit(false), + m_expect_unmount(false) { struct sigaction sa; struct iovec *iov = NULL; @@ -979,7 +980,7 @@ void MockFS::read_request(mockfs_buf_in &in, ssize_t &res) { } res = read(m_fuse_fd, &in, sizeof(in)); - if (res < 0 && !m_quit) { + if (res < 0 && errno != EBADF && !m_quit && !m_expect_unmount) { m_quit = true; FAIL() << "read: " << strerror(errno); } diff --git a/tests/sys/fs/fusefs/mockfs.hh b/tests/sys/fs/fusefs/mockfs.hh index 4b0628d34dd7..f98a5337c9d1 100644 --- a/tests/sys/fs/fusefs/mockfs.hh +++ b/tests/sys/fs/fusefs/mockfs.hh @@ -360,6 +360,9 @@ class MockFS { /* Tell the daemon to shut down ASAP */ bool m_quit; + /* Tell the daemon that the server might forcibly unmount us */ + bool m_expect_unmount; + /* Create a new mockfs and mount it to a tempdir */ MockFS(int max_read, int max_readahead, bool allow_other, bool default_permissions, bool push_symlinks_in, bool ro,