From owner-svn-ports-head@FreeBSD.ORG Wed Jul 30 12:52:36 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D2EC0B72; Wed, 30 Jul 2014 12:52:36 +0000 (UTC) Received: from 0.mx.codelabs.ru (0.mx.codelabs.ru [144.206.233.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 696AA2922; Wed, 30 Jul 2014 12:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codelabs.ru; s=three; h=Sender:In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=OB0cbQNqu6DG/oCS5h2/9CgUrfqugEsIx0NNRMQ0FiU=; b=fiP2u0BFMVz/HriGJ0CMiSWocWR1G4OR4BROcwcvuu0h9IunTiIzDur1SLez8jCXwdg/ITTeBZTXNDB9RFUbtF/vXTuM6jxHW7aBZSTdWk8+SvXnprADPfnnJ7Ht4jZ8dSPNOgEeZzpmxPa8XA6P1OQT4OsX1EdauB13NxHkY0P0O4UW9QhB2btjiILhDh6Fut/Vyh61/nGZL5o7/qeUsPC2rXzbpM7maIgqbotc33IsbnWAHqQC/GfrFaoDPPher8gQ/fz4XysdGNshyjLdKQtWZ1+H2VXjZAGNS/XlCMy9djeuNmduc9XVziMWfQTp3+z9RfA8mrkxJYDskDADhbM2KTIOLbYbMIHP85huKe/40aoKaV+YUfoAIaIl4nUqlz7EfhaIhl3xUDjgk+apgfSglngX/mPt/qNUA8HQRtIkCK/CC+rSKVaUnNqBNE4RaetZqwdpIm7eqnNSLk2N3aOnRthfjvpSjAZ4EFql2vuxdO8a+ubxNKR1hgUVcfsr5WPLfe/x0Wo4CMzo9dbahUu5DTDKML8N156luf9Roa68lqPQPTBKSpF7cbjUtAVeeoM/0Aj/f78zpLiAGzZ7g52bbwetKJej28VkxI5Qlb3AW9GaRGHI3xFL022RL0VFRXjINBSO0GjOGhpiWDTprJHdiUdzUGSlTXnsFIewnxI=; Received: from void.codelabs.ru (void.codelabs.ru [144.206.233.66]) by 0.mx.codelabs.ru with esmtpsa (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) id 1XCTMn-000DWF-GA; Wed, 30 Jul 2014 16:52:25 +0400 Date: Wed, 30 Jul 2014 16:52:21 +0400 From: Eygene Ryabinkin To: Mathieu Arnold Subject: make makepatch and per-file diffs [WAS: Re: svn commit: r363361 - in head/editors/fte: . files] Message-ID: References: <201407291646.s6TGkjHH090335@svn.freebsd.org> <41D25BC1-AC62-4280-A342-8A2BDD84B1E0@adamw.org> <20140730070412.GA97692@FreeBSD.org> <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk> <53D89EBF.4080805@marino.st> <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st> <6270029E710D3C52B60B6224@atuin.in.mat.cc> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XkdrZ7OMnakiJ6dL" Content-Disposition: inline In-Reply-To: <6270029E710D3C52B60B6224@atuin.in.mat.cc> Sender: rea@codelabs.ru Cc: svn-ports-head@freebsd.org, Max Brazhnikov , Alexey Dokuchaev , svn-ports-all@freebsd.org, marino@freebsd.org, William Grzybowski , ports-committers@freebsd.org, Adam Weinberger X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jul 2014 12:52:37 -0000 --XkdrZ7OMnakiJ6dL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Wed, Jul 30, 2014 at 10:08:05AM +0200, Mathieu Arnold wrote: > But, I think you're missing the point, who cares what the separator > is ? All it needs to do is work when I run make patch. Also, all > one needs to know is that to generate the patches, you run make > makepatch. Pardon me, but this is a short-term or port's user point of view. Port maintainers may (and should) also have some idea on what's the patch is about and to have not just single patch file for a single modified file, but have different hunks that are related to a single change to be grouped together in one file. That horribly eases the maintainership and its transfer to other persons (especially the latter). Currently 'make makepatch' takes us even behind CVS era where you had one diff for each commit and each file: it glues together all (possibly unrelated) changes in a single file to a single diff. Yes, there is an issue for patch ordering and 'make makepatch' tries to solve precisely that problem putting everything to per-file diffs. But it misses the whole point of having good quality patches inside files/ and does only poor-man work. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --XkdrZ7OMnakiJ6dL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iL4EABEKAGYFAlPY6oVfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDgyRkUwNkJDRDQ5N0MwREU0OUVDNEZGMDE2 QUY5RUFFODE1MkVDRkIACgkQFq+eroFS7PsGigD/T8haRbeVyRVIDPj+hu5vGcLh Ur+SA18eD9F0Q0QscwUA/0cj46wpDoRQIkzQFF8AV7Nb6VvrM2hT0xq+js88RMwJ =jpik -----END PGP SIGNATURE----- --XkdrZ7OMnakiJ6dL--