From owner-cvs-src@FreeBSD.ORG Thu May 13 21:12:43 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9895216A4CF for ; Thu, 13 May 2004 21:12:43 -0700 (PDT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 0282D43D53 for ; Thu, 13 May 2004 21:12:43 -0700 (PDT) (envelope-from nate@root.org) Received: (qmail 93416 invoked by uid 1000); 14 May 2004 04:12:45 -0000 Date: Thu, 13 May 2004 21:12:45 -0700 (PDT) From: Nate Lawson To: John Polstra In-Reply-To: <20040514012935.023B916A545@hub.freebsd.org> Message-ID: <20040513211215.K93408@root.org> References: <20040514012935.023B916A545@hub.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/boot/i386/libi386 biosacpi.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2004 04:12:43 -0000 On Thu, 13 May 2004, John Polstra wrote: > jdp 2004/05/13 18:29:21 PDT > > FreeBSD src repository > > Modified files: > sys/boot/i386/libi386 biosacpi.c > Log: > Fix a potential stack buffer overflow on systems whose ACPI OEMID > fills its field (6 characters). In that case the OEMID is not > null-terminated, and the sprintf that was used would copy up to the > next null byte, which could be pretty far away. > > Revision Changes Path > 1.8 +2 -2 src/sys/boot/i386/libi386/biosacpi.c Thanks for fixing this and running it past me for review. -Nate