From owner-svn-ports-head@freebsd.org  Mon Aug 22 17:16:31 2016
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id B3B99BC2C5F;
 Mon, 22 Aug 2016 17:16:31 +0000 (UTC)
 (envelope-from marino@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 842DA1200;
 Mon, 22 Aug 2016 17:16:31 +0000 (UTC)
 (envelope-from marino@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u7MHGUTk029810;
 Mon, 22 Aug 2016 17:16:30 GMT (envelope-from marino@FreeBSD.org)
Received: (from marino@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u7MHGUwW029809;
 Mon, 22 Aug 2016 17:16:30 GMT (envelope-from marino@FreeBSD.org)
Message-Id: <201608221716.u7MHGUwW029809@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: marino set sender to
 marino@FreeBSD.org using -f
From: John Marino <marino@FreeBSD.org>
Date: Mon, 22 Aug 2016 17:16:30 +0000 (UTC)
To: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: svn commit: r420625 - head/security/libargon2
X-SVN-Group: ports-head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Aug 2016 17:16:31 -0000

Author: marino
Date: Mon Aug 22 17:16:30 2016
New Revision: 420625
URL: https://svnweb.freebsd.org/changeset/ports/420625

Log:
  security/libargon2 is not jobs safe
  
  This concurrent flaw is pretty awful but easily fixed.
  The "all" target depends on "clean $(RUN) libs".
  In a multijob invocation, these targets all start building at the
  same time beccause there's no requirement to clean before building.
  As a result, it's possible that some object files get built before the
  clean target runs, which deletes the built files.
  
  Probably this can be solved by simply removing the "clean" target which
  should be unnecessary in a ports build area.  I'll leave that to the
  maintainer to either patch or notify upstream of this obvious makefile
  flaw.

Modified:
  head/security/libargon2/Makefile

Modified: head/security/libargon2/Makefile
==============================================================================
--- head/security/libargon2/Makefile	Mon Aug 22 16:49:02 2016	(r420624)
+++ head/security/libargon2/Makefile	Mon Aug 22 17:16:30 2016	(r420625)
@@ -18,6 +18,8 @@ GH_TAGNAME=	4625cc5
 USES=		gmake
 USE_LDCONFIG=	yes
 
+MAKE_JOBS_UNSAFE=	yes
+
 do-install:
 	${INSTALL_DATA} ${WRKSRC}/include/argon2.h ${STAGEDIR}${PREFIX}/include
 	${INSTALL_LIB} ${WRKSRC}/libargon2.a ${STAGEDIR}${PREFIX}/lib