From owner-freebsd-current Tue Jan 25 1:18:17 2000 Delivered-To: freebsd-current@freebsd.org Received: from anchor-post-31.mail.demon.net (anchor-post-31.mail.demon.net [194.217.242.89]) by hub.freebsd.org (Postfix) with ESMTP id CA94E150C6 for ; Tue, 25 Jan 2000 01:18:14 -0800 (PST) (envelope-from dfr@nlsystems.com) Received: from nlsys.demon.co.uk ([158.152.125.33] helo=herring.nlsystems.com) by anchor-post-31.mail.demon.net with esmtp (Exim 2.12 #1) id 12D273-000PbB-0V; Tue, 25 Jan 2000 09:18:13 +0000 Received: from salmon.nlsystems.com (salmon.nlsystems.com [10.0.0.3]) by herring.nlsystems.com (8.9.3/8.8.8) with ESMTP id JAA91303; Tue, 25 Jan 2000 09:20:22 GMT (envelope-from dfr@nlsystems.com) Date: Tue, 25 Jan 2000 09:17:05 +0000 (GMT) From: Doug Rabson To: Warner Losh Cc: Nick Hibma , FreeBSD CURRENT Mailing List Subject: Re: APM still ignoring DEVICE_SUSPEND errors In-Reply-To: <200001241836.LAA04877@harmony.village.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Mon, 24 Jan 2000, Warner Losh wrote: > In message Nick Hibma writes: > : The following patch fixes two things: First, DEVICE_SUSPEND errors are > : no longer ignored. Since we have defaults for methods we should no > : longer ignore these errors. Also, DEVICE_RESUME wasn't done when the > : apm_suspend_system event failed. > > I had similar patches that workede several months ago, but they have > since been lost. > > : Second, in the ordering of DEVICE_* and apm_hook_* is not symmetric for > : suspend and resume. The patch reverses the resume case as well to be > : > : apm_hook_resume(...) > : DEVICE_RESUME(root) > : > : Send me some feedback on this. I've mailed the people mentioned in the > : head of the file, but so far got no response. I would like to make sure > : we get this right when USB devices are used. Some of them don't suspend > : and the suspend should be refused in that case. > > Any reason to not shoot the apm_hook_{suspend,resume} in the head and > just use newbus suspend/resume everywhere? Are there any non-newbus devices which need suspend/resume? I think the i386 clock uses the apm hooks but I might be misremembering. -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 442 9037 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message