From owner-cvs-all Sun Mar 1 01:14:28 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id BAA18767 for cvs-all-outgoing; Sun, 1 Mar 1998 01:14:28 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from critter.freebsd.dk (critter.freebsd.dk [195.8.129.14]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id BAA18744; Sun, 1 Mar 1998 01:14:17 -0800 (PST) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.8.7/8.8.5) with ESMTP id KAA04620; Sun, 1 Mar 1998 10:09:08 +0100 (CET) To: Mike Smith cc: Bruce Evans , cvs-committers@FreeBSD.ORG, msmith@FreeBSD.ORG Subject: Re: cvs commit: src/sys/gnu/ext2fs ext2_vnops.c In-reply-to: Your message of "Sat, 28 Feb 1998 17:34:31 PST." <199803010134.RAA06838@dingo.cdrom.com> Date: Sun, 01 Mar 1998 10:09:08 +0100 Message-ID: <4618.888743348@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk In message <199803010134.RAA06838@dingo.cdrom.com>, Mike Smith writes: >> > Modified files: >> > sys/gnu/ext2fs ext2_vnops.c >> > Log: >> > Add local stup putpages/getpages routines. >> > Submitted by: Terry Lambert >> >> I think putpages/getpages should go in default_vnodeop_entries[] like >> dima suggested. >> >> Anyway, the patch was not suitable for committing verbatim, because it >> has many style bugs, starting with disordering of lists recently sorted >> by phk. > >Aside from the issue of parenthesised arguments to return, what other >style violations are you aware of? > >I see no 'recent sorting' activity by phk in the affected file, nor any >clear ordering to the only thing in the file that could reasonably be >described as a list. Search for "VOP" in the committers log. It happened some months ago when I spent a great deal of time avoiding identical VOP implementations in multiple filesystems. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." "Drink MONO-tonic, it goes down but it will NEVER come back up!" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message