From owner-freebsd-bugs@FreeBSD.ORG Mon Apr 18 11:50:23 2005 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9F0B816A4CE for ; Mon, 18 Apr 2005 11:50:23 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D15A43D54 for ; Mon, 18 Apr 2005 11:50:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j3IBoNMR004107 for ; Mon, 18 Apr 2005 11:50:23 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j3IBoNAv004106; Mon, 18 Apr 2005 11:50:23 GMT (envelope-from gnats) Resent-Date: Mon, 18 Apr 2005 11:50:23 GMT Resent-Message-Id: <200504181150.j3IBoNAv004106@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Elmar Bartel Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C0C416A4CE for ; Mon, 18 Apr 2005 11:44:16 +0000 (GMT) Received: from www.freebsd.org (www.freebsd.org [216.136.204.117]) by mx1.FreeBSD.org (Postfix) with ESMTP id 41E2543D55 for ; Mon, 18 Apr 2005 11:44:16 +0000 (GMT) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.13.1/8.13.1) with ESMTP id j3IBiFAd022504 for ; Mon, 18 Apr 2005 11:44:15 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.13.1/8.13.1/Submit) id j3IBiFnM022503; Mon, 18 Apr 2005 11:44:15 GMT (envelope-from nobody) Message-Id: <200504181144.j3IBiFnM022503@www.freebsd.org> Date: Mon, 18 Apr 2005 11:44:15 GMT From: Elmar Bartel To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-2.3 Subject: bin/80064: Incorrect use of strlcat X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Apr 2005 11:50:23 -0000 >Number: 80064 >Category: bin >Synopsis: Incorrect use of strlcat >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Apr 18 11:50:22 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Elmar Bartel >Release: 5.2 >Organization: leo.org >Environment: FreeBSD pegasus.devsoft.com 5.2-CURRENT FreeBSD 5.2-CURRENT #0: Sat Oct 2 14:17:47 CEST 2004 elmar@pegasus.devsoft.com:/usr/src/sys/i386/compile/PEGASUS i386 >Description: Version 1.34 of /usr/src/sbin/dump/main.c changed the call of strncat to strlcat, but it didn't change the size parameter: Version 1.33 used (line 602) (void)strncat(rawbuf, "/r", MAXPATHLEN - 1 - strlen(rawbuf)); (void)strncat(rawbuf, dp + 1, MAXPATHLEN - 1 - strlen(rawbuf)); Now it reads: (void)strlcat(rawbuf, "/r", MAXPATHLEN - 1 - strlen(rawbuf)); (void)strlcat(rawbuf, dp + 1, MAXPATHLEN - 1 - strlen(rawbuf)); >How-To-Repeat: Nothing to repeat >Fix: Change the lines in question to: (void)strlcat(rawbuf, "/r", MAXPATHLEN); (void)strlcat(rawbuf, dp + 1, MAXPATHLEN); And also the line with strlcpy (3 line previously) could be changed: (void)strlcpy(rawbuf, cp, MAXPATHLEN); >Release-Note: >Audit-Trail: >Unformatted: