Date: Mon, 25 Dec 1995 11:37:33 -0500 (EST) From: James FitzGibbon <james@else.net> To: current@freebsd.org Subject: Suggestion for target 'includes' Message-ID: <Pine.LNX.3.91.951225112834.10875A-100000@else.net>
next in thread | raw e-mail | index | archive | help
I'd like to make a suggestion for a slight change to the /usr/src/Makefile target 'includes'. Granted, it's a change that shouldn't be required if everything has been done by the book, but it would have saved me a lot of trouble trying to build current: The target runs an rm -rf on /usr/include followed by an mtree only if CLOBBER is defined. Consider what happens if the directories that mtree would install are not there (corrupted include directory) but CLOBBER is not defined - all includes in the main directory are installed fine, but something like /usr/include/readline/history.h never gets there. Instead, the five files that should be in the readline directory are copies successively over the file named /usr/include/readline. This causes failed builds duirng a make world, but not until the compile is all the way into 'make all gnu/usr.bin'. It's hard to fix this error without digging, and then running a -DCLOBBEr (which negates most of what you built before the crash). Since mtree is already being called in a non-destructive manner, why not move it out of the .if-.endif clause and make it run whether CLOBBER is defined or not? That would save a build from failing halfway through for stupid reasons. j.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.LNX.3.91.951225112834.10875A-100000>