From owner-freebsd-current@FreeBSD.ORG  Tue Sep  6 14:03:55 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5FE5E16A41F;
	Tue,  6 Sep 2005 14:03:55 +0000 (GMT)
	(envelope-from keramida@freebsd.org)
Received: from kane.otenet.gr (kane.otenet.gr [195.170.0.95])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A149E43D46;
	Tue,  6 Sep 2005 14:03:54 +0000 (GMT)
	(envelope-from keramida@freebsd.org)
Received: from orion.daedalusnetworks.priv (aris.bedc.ondsl.gr [62.103.39.226])
	by kane.otenet.gr (8.13.4/8.13.4/Debian-1) with SMTP id j86E3gwc011241; 
	Tue, 6 Sep 2005 17:03:43 +0300
Received: from orion.daedalusnetworks.priv (orion [127.0.0.1])
	by orion.daedalusnetworks.priv (8.13.4/8.13.4) with ESMTP id
	j86E3go5027801; Tue, 6 Sep 2005 17:03:42 +0300 (EEST)
	(envelope-from keramida@freebsd.org)
Received: (from keramida@localhost)
	by orion.daedalusnetworks.priv (8.13.4/8.13.4/Submit) id j86E3fch027800;
	Tue, 6 Sep 2005 17:03:41 +0300 (EEST)
	(envelope-from keramida@freebsd.org)
X-Authentication-Warning: orion.daedalusnetworks.priv: keramida set sender to
	keramida@freebsd.org using -f
Date: Tue, 6 Sep 2005 17:03:41 +0300
From: Giorgos Keramidas <keramida@freebsd.org>
To: Craig Rodrigues <rodrigc@crodrigues.org>
Message-ID: <20050906140340.GA27780@orion.daedalusnetworks.priv>
References: <20050903133344.GA633@gothmog.gr>
	<20050905162713.GA92142@crodrigues.org>
	<20050905175826.GL69481@zxy.spb.ru>
	<20050906015418.GA590@gothmog.gr>
	<20050906120809.GP69481@zxy.spb.ru>
	<20050906124508.GA27413@orion.daedalusnetworks.priv>
	<20050906133221.GA903@crodrigues.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050906133221.GA903@crodrigues.org>
Cc: rodrigc@freebsd.org, freebsd-current@freebsd.org, mirya@matrix.kiev.ua,
	Slawa Olhovchenkov <slw@zxy.spb.ru>
Subject: Re: moused related panic
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 06 Sep 2005 14:03:55 -0000

On 2005-09-06 09:32, Craig Rodrigues <rodrigc@crodrigues.org> wrote:
> On Tue, Sep 06, 2005 at 03:45:08PM +0300, Giorgos Keramidas wrote:
> > I don't really like the "hackish" way my last patch avoids the panics, because
> > assuming that a default font_width of 8 is ok is probably one gratuitous
> > assumption too many.  I haven't had a chance to look at the font changing
> > implementation to see if scp->font_width can be set elsewhere to a non-zero
> > value or if it's supposed to be zero in text modes.
>
> Can you try this:
>
> Index: scvidctl.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/syscons/scvidctl.c,v
> retrieving revision 1.35
> diff -u -u -r1.35 scvidctl.c
> --- scvidctl.c	30 Aug 2005 18:58:16 -0000	1.35
> +++ scvidctl.c	6 Sep 2005 13:31:30 -0000
> @@ -145,6 +145,8 @@
>  	return ENODEV;
>
>      /* adjust argument values */
> +    if (fontwidth <= 0)
> +	fontwidth = info.vi_cwidth;
>      if (fontsize <= 0)
>  	fontsize = info.vi_cheight;
>      if (fontsize < 14) {

This looks promising.  I'll try it out, after reverting my local patch
in a while.

Thanks :)