From owner-freebsd-current@FreeBSD.ORG  Tue Jun 10 04:14:45 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A4E2137B401
	for <current@FreeBSD.ORG>; Tue, 10 Jun 2003 04:14:45 -0700 (PDT)
Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au
	[210.50.30.52])	by mx1.FreeBSD.org (Postfix) with ESMTP id 17FC843FB1
	for <current@FreeBSD.ORG>; Tue, 10 Jun 2003 04:14:45 -0700 (PDT)
	(envelope-from tim@robbins.dropbear.id.au)
Received: from dilbert.robbins.dropbear.id.au (210.50.219.125) by
	smtp01.syd.iprimus.net.au (7.0.015)
	id 3EDD516E00157BC2; Tue, 10 Jun 2003 21:14:40 +1000
Received: by dilbert.robbins.dropbear.id.au (Postfix, from userid 1000)
	id 397E0C911; Tue, 10 Jun 2003 21:08:11 +1000 (EST)
Date: Tue, 10 Jun 2003 21:08:10 +1000
From: Tim Robbins <tjr@FreeBSD.ORG>
To: Donn Miller <dmmiller@cvzoom.net>
Message-ID: <20030610210810.A90413@dilbert.robbins.dropbear.id.au>
References: <3EE43394.6090802@cvzoom.net>
	<20030609203355.A51153@dilbert.robbins.dropbear.id.au>
	<3EE49AE2.6010701@cvzoom.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <3EE49AE2.6010701@cvzoom.net>;
	from dmmiller@cvzoom.net on Mon, Jun 09, 2003 at 10:34:10AM -0400
cc: current@FreeBSD.ORG
Subject: Re: panic: mdconfig on an iso file mounted on smbfs
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 10 Jun 2003 11:14:45 -0000

On Mon, Jun 09, 2003 at 10:34:10AM -0400, Donn Miller wrote:

> Thanks, that worked.  But I'm seeing the same thing as you. i.e., panic 
> if I reboot without running mdconfig -d first.  Here is the backtrace of 
> the ensuing panic:
> 
> http://users.zoominternet.net/~dmmiller/freebsd/panic-2

Here's a patch that should fix the panic. Let me know whether it does,
and also whether it causes any new problems (I'm not very confident in
the patch's correctness).

--- sys/fs/smbfs/smbfs_subr.c.orig	Tue Jun 10 21:09:50 2003
+++ sys/fs/smbfs/smbfs_subr.c	Tue Jun 10 21:06:23 2003
@@ -270,6 +270,8 @@
 			return ENAMETOOLONG;
 		}
 		*npp++ = np;
+		if ((np->n_flag & NREFPARENT) == 0)
+			break;
 		np = VTOSMB(np->n_parent);
 	}
 /*	if (i == 0)