From owner-svn-src-head@FreeBSD.ORG Tue Jul 31 17:07:22 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 67A56106567E; Tue, 31 Jul 2012 17:07:22 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-wg0-f42.google.com (mail-wg0-f42.google.com [74.125.82.42]) by mx1.freebsd.org (Postfix) with ESMTP id 995CF8FC15; Tue, 31 Jul 2012 17:07:21 +0000 (UTC) Received: by wgbfm10 with SMTP id fm10so3536967wgb.1 for ; Tue, 31 Jul 2012 10:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=oqkW+lmhu4DKGyYi+8W4ih3VqRVcAb5dYMGAOJCcMU0=; b=EZzt66fYqjm31Vz79RKNSzdB5e6XcSz+cBjDWsHQ17PkUK0zYLaYtPk8YJwY9nNPgU VfVmKsS4GYhSl4+oxXkA0pyYP5UWcds2WVe46BcLfKcgzhz+Y7YlnsaWYk7/u2+2cwgp tnINLUvCm6rk/e7MiQy88e18PNcclMTv8Kyi1NRBL+j9n/zcBk3yHdlee2BGKBlwlUn+ WUkIcwWL4w+s+aOXVAQ+Ux/8078DuntiU5Ct2o1AuXLdVV/IZV4sL0Tv2njmagUuONRv l6cehCm9rzOfO2bi7EFU1tOwZHmAYZ9WDGlFnSj3SqhOngeIiVPCcsP1/xITHPTDo+rY tZOQ== Received: by 10.180.107.103 with SMTP id hb7mr8689240wib.3.1343754434730; Tue, 31 Jul 2012 10:07:14 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (93-127-73-162.static.vega-ua.net. [93.127.73.162]) by mx.google.com with ESMTPS id bc2sm1532650wib.0.2012.07.31.10.07.12 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 31 Jul 2012 10:07:14 -0700 (PDT) Sender: Alexander Motin Message-ID: <501810BF.9010008@FreeBSD.org> Date: Tue, 31 Jul 2012 20:07:11 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120628 Thunderbird/13.0.1 MIME-Version: 1.0 To: Sean Bruno References: <201207311058.q6VAwp18019777@svn.freebsd.org> <1343751146.2957.3.camel@powernoodle.corp.yahoo.com> In-Reply-To: <1343751146.2957.3.camel@powernoodle.corp.yahoo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-src-head@FreeBSD.org" , "svn-src-all@FreeBSD.org" , "src-committers@FreeBSD.org" Subject: Re: svn commit: r238943 - head/sys/dev/acpica X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Jul 2012 17:07:22 -0000 On 31.07.2012 19:12, Sean Bruno wrote: > On Tue, 2012-07-31 at 03:58 -0700, Alexander Motin wrote: >> To help with diagnostics, add C-state type into >> dev.cpu.X.cx_supported. > > Pretty sure that this breaks /etc/rc.d/power_profile No, it doesn't. I've checked it beforehand. At least in my case variable was correctly set to C3. > Andiry and I went back and forth on this specific thing quite a bit. If > you note my commit/revert at svn r238004 and r238009 where I did a > similar thing and then had to yank it out. > > there's a lot of discussion around this point on the acpi mailing lists. > http://lists.freebsd.org/pipermail/freebsd-acpi/2012-July/007645.html I knew about that change and its revert. But it was much more invasive, substituting C-state index with C-state type, that I also consider incorrect. My change is much more simple. Yes, it may affect some POLA, but that is all. I wanted to do this for several years, and I believe that in this case benefits overweight negative side. But if someone tell I should back it out, I will. -- Alexander Motin